Date: Thu, 11 Oct 2012 07:00:26 +0200 From: Davide Italiano <davide@freebsd.org> To: Christian Brueffer <brueffer@freebsd.org> Cc: attilio@freebsd.org, svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Mateusz Guzik <mjg@freebsd.org> Subject: Re: svn commit: r238539 - head/sys/fs/smbfs Message-ID: <CACYV=-Ej1o2cQnU4WzKtFkb3M%2B%2BzKLBuMdH%2BT-ASmRomogzp-w@mail.gmail.com> In-Reply-To: <5006A7DD.9050509@FreeBSD.org> References: <201207162207.q6GM7UNS087234@svn.freebsd.org> <CAJ-FndA%2BEEr9OfoRz6%2BBP7sk_3%2BdrxWx0zs4WbQhMLq9A0D_Pw@mail.gmail.com> <5006A7DD.9050509@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Jul 18, 2012 at 2:11 PM, Christian Brueffer <brueffer@freebsd.org> wrote: > On 7/17/12 0:10 , Attilio Rao wrote: >> 2012/7/16 Christian Brueffer <brueffer@freebsd.org>: >>> Author: brueffer >>> Date: Mon Jul 16 22:07:29 2012 >>> New Revision: 238539 >>> URL: http://svn.freebsd.org/changeset/base/238539 >>> >>> Log: >>> Simply error handling by moving the allocation of np down to where it is >>> actually used. While here, improve style a little. >> >> Too bad that the biggest bug here is still in place. >> Right now smbfs inserts in the mount list half-constructed vnodes. >> Maybe you are interested in fixing this? >> > > I can give it a shot, no promises though. > > Cheers, > > Chris > This patch should fix the half-constructed vnode insertion issue. Can you give it a look, Attilio? http://people.freebsd.org/~davide/ix/smbfs_norollhash.diff Moreover, it makes the code relying on the global vfs_hash table, now it works using an home-made local hash table for vnodes. Thanks Davide
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CACYV=-Ej1o2cQnU4WzKtFkb3M%2B%2BzKLBuMdH%2BT-ASmRomogzp-w>