Date: Sun, 8 Jan 2017 11:17:14 +0200 From: Konstantin Belousov <kostikbel@gmail.com> To: "Conrad E. Meyer" <cem@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r311665 - head/sys/fs/cd9660 Message-ID: <20170108091714.GF2349@kib.kiev.ua> In-Reply-To: <201701080621.v086LnAX019001@repo.freebsd.org> References: <201701080621.v086LnAX019001@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Jan 08, 2017 at 06:21:49AM +0000, Conrad E. Meyer wrote: > +/* > + * When ino_t becomes 64-bit, we can remove this definition in favor of ino_t. > + */ > +#define cd_ino_t uint64_t > + Why the type is defined and not typedef-ed ? Also, I do not think that it is good idea to rely on specific size of the special-purpose system types, like ino_t, even if it is only an intent. Both because the types can change, and because it reduces the usefulness of the code outside the FreeBSD content (our code is often taken into weird embedded systems), where system types might be different.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20170108091714.GF2349>