Date: Thu, 22 Feb 2018 06:18:26 +0000 From: Tommi Pernila <tommi.pernila@iki.fi> To: Eric McCorkle <eric@metricspace.net> Cc: Warner Losh <imp@bsdimp.com>, "[ScaleEngine] Allan Jude" <allan.jude@scaleengine.com>, freebsd-current <freebsd-current@freebsd.org>, imp@freebsd.org Subject: Re: GELI with UEFI supporting Boot Environments goes to HEAD when? Message-ID: <CABHD1wRu_C4dPvzt%2BxMsYYYjFNJ1%2B78ne4cLsuCxr=YrN%2BhfFA@mail.gmail.com> In-Reply-To: <f17bbb44-6735-e252-ba75-bd0b4f685d9d@metricspace.net> References: <CABHD1wRyrmXp5R_ViERa-MnJnVKN-U551SWt%2Behm6r%2B3viydxg@mail.gmail.com> <CANCZdfp-bYi2fFJi5ashPLwjnwKWeoepiPt23LfPORU1EpKNGg@mail.gmail.com> <CABHD1wQU_6wHw96%2BLguVuqmwqY04%2Bn7NPcy6rSgn4QdKZpF3Kg@mail.gmail.com> <0e75a2ba-9a59-8301-a678-68a822025bd6@metricspace.net> <CABHD1wS-RoxP5fsCYgH61BsPsad_OPC4FZSUCUi6EfsWyXRzQA@mail.gmail.com> <9df63df2-9d61-4106-f360-347411869b41@metricspace.net> <f17bbb44-6735-e252-ba75-bd0b4f685d9d@metricspace.net>
next in thread | previous in thread | raw e-mail | index | archive | help
Awesome, thanks for the update and the work that you have done! Now we just need some more reviewers eyes on the code :) Br, Tommi On Thu, 22 Feb 2018 at 2.03, Eric McCorkle <eric@metricspace.net> wrote: > FYI, I just IFC'ed everything, and the current patches are still fine. > > Also, the full GELI + standalone loader has been deployed on one of my > laptops for some time now. > > On 02/21/2018 18:15, Eric McCorkle wrote: > > The GELI work could be merged at this point, though it won't be usable > > without an additional patch to enable loader-only operation. The > > patches are currently up for review: > > > > This is the order in which they'd need to be merged: > > > > > > https://reviews.freebsd.org/D12732 > > > > This one changes the efipart device. Toomas Soome identified some > > problems, which I have addressed. He has not re-reviewed it, however. > > > > > > https://reviews.freebsd.org/D12692 > > > > This adds some crypto code needed for GELI. It simply adds new code, > > and doesn't conflict with anything. > > > > > > https://reviews.freebsd.org/D12698 > > > > This adds the EFI KMS interface code, and has the EFI loader pass keys > > into the keybuf interface. > > > > > > I can't post the main GELI driver until those get merged, as it depends > > on them. It can be found on the geli branch on my github freebsd > > repository, however. > > > > > > Additionally, you need this patch, which allows loader.efi to function > > when installed directly to the ESP: > > > > https://reviews.freebsd.org/D13497 > > > > On 02/20/2018 22:56, Tommi Pernila wrote: > >> Hi Eric, > >> > >> could you provide a brief update how the work is going? > >> > >> > >> Br, > >> > >> Tommi > >> > >> > >> On Nov 16, 2017 04:29, "Eric McCorkle" <eric@metricspace.net > >> <mailto:eric@metricspace.net>> wrote: > >> > >> Right, so basically, the remaining GELI patches are against loader, > and > >> most of them can go in independently of the work on removing boot1. > >> There's a unanimous consensus on getting rid of boot1 which > includes its > >> original author, so that's going to happen. > >> > >> > >> For GELI, we have the following (not necessarily in order): > >> > >> a) Adding the KMS interfaces, pseudo-device, and kernel keybuf > >> interactions > >> b) Modifications to the efipart driver > >> c) boot crypto > >> d) GELI partition types (not strictly necessary) > >> > >> Then there's the GELI driver itself. (a) and (c) are good to land, > (b) > >> needs some more work after Toomas Soome pointed out a legitimate > >> problem, and (d) actually needs a good bit more code (but again, > it's > >> more cosmetic). Additionally, the GELI driver will need further > mods to > >> efipart to be written (nothing too big). But we could go ahead > with (a) > >> and (c), as they've already been proven to work. > >> > >> I'd wanted to have this stuff shaped up sooner, but I'm preoccupied > with > >> the 7th RISC-V workshop at the end of the month. > >> > >> Once this stuff is all in, loader should handle any GELI volumes it > >> finds, and it should Just Work once boot1 is gone. > >> > >> > > _______________________________________________ > > freebsd-current@freebsd.org mailing list > > https://lists.freebsd.org/mailman/listinfo/freebsd-current > > To unsubscribe, send any mail to " > freebsd-current-unsubscribe@freebsd.org" > > >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CABHD1wRu_C4dPvzt%2BxMsYYYjFNJ1%2B78ne4cLsuCxr=YrN%2BhfFA>