Date: Fri, 03 Jun 2022 07:45:34 +0200 From: Kristof Provost <kp@FreeBSD.org> To: Kubilay Kocak <koobs@FreeBSD.org> Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: a37e0e6de652 - main - pf: fix more syncookie memory leaks Message-ID: <3C8AD404-31EC-49C6-B9D2-2F8888E22C7D@FreeBSD.org> In-Reply-To: <b1bd91d9-e133-3bf6-0003-5e4443939537@FreeBSD.org> References: <202206021818.252IIAdK087215@gitrepo.freebsd.org> <b1bd91d9-e133-3bf6-0003-5e4443939537@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 3 Jun 2022, at 3:36, Kubilay Kocak wrote: > On 3/06/2022 4:18 am, Kristof Provost wrote: >> The branch main has been updated by kp: >> >> URL: https://cgit.FreeBSD.org/src/commit/?id=3Da37e0e6de6527a7eaddea8e= 28f5e4b3427fba1a4 >> >> commit a37e0e6de6527a7eaddea8e28f5e4b3427fba1a4 >> Author: Franco Fichtner <franco@opnsense.org> >> AuthorDate: 2022-06-02 16:27:43 +0000 >> Commit: Kristof Provost <kp@FreeBSD.org> >> CommitDate: 2022-06-02 18:17:25 +0000 >> >> pf: fix more syncookie memory leaks >> Allocate memory for packed nvlists in M_NVLIST, as nvlist_pac= k() does >> this as well, and we use the same variable interchangable with th= e >> memory we allocate. When we free it we can end up freeing from th= e wrong >> zone, leaking memory. >> Reviewed by: kp >> Differential Revision: https://reviews.freebsd.org/D35385 > > Hi Kristof, > > Are stable{13,12} affected or only introduced in main? > They are. This should be MFC=E2=80=99d, but I forgot to tag it. It=E2=80=99= s already on my todo list though. Kristof
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3C8AD404-31EC-49C6-B9D2-2F8888E22C7D>