Date: Thu, 2 Dec 1999 16:21:20 -0800 (PST) From: Kirk McKusick <mckusick@chez.McKusick.COM> To: gallatin@cs.duke.edu Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org, mckusick@mckusick.com Subject: Re: cvs commit: src/sys/sys mount.h src/sys/kern vfs_bio.c src/sys/miscfs/specfs spec_vnops.c Message-ID: <199912030021.QAA50864@chez.McKusick.COM> In-Reply-To: <14405.36736.721812.91039@grasshopper.cs.duke.edu>
next in thread | previous in thread | raw e-mail | index | archive | help
From owner-cvs-committers@FreeBSD.org Wed Dec 1 13:27:14 1999
To: Kirk McKusick <mckusick@FreeBSD.org>
Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/sys mount.h src/sys/kern vfs_bio.c
src/sys/miscfs/specfs spec_vnops.c
In-Reply-To: <199912010209.SAA68538@freefall.freebsd.org>
References: <199912010209.SAA68538@freefall.freebsd.org>
Kirk McKusick writes:
> out. The old mount binary is completely compatible, the only
> reason to install a new mount is to get the read counts printed.
Unless you are running on an alpha, where sizeof(long) == 8 ;-)
There you are stuck:
<...>
pid 11 (fsck), uid 0: exited on signal 11 (core dumped)
Segmentation fault - core dumped
Unknown error in reboot
<...>
I'd like to see mount stay backwards/forwards compatible if possible.
There are 2 ways to fix this -- adjust MNAMELEN down on alpha, or
change the types of the added fields from longs to u_int32_t's.
I have verified the following (adjusting MNAMELEN down to 72) works,
should I go ahead & commit it?
Index: mount.h
===================================================================
RCS file: /home/ncvs/src/sys/sys/mount.h,v
retrieving revision 1.85
diff -u -c -r1.85 mount.h
cvs diff: conflicting specifications of output style
*** mount.h 1999/12/01 02:09:19 1.85
--- mount.h 1999/12/01 21:07:37
***************
*** 67,73 ****
--- 67,78 ----
*/
#define MFSNAMELEN 16 /* length of fs type name, including null */
+ #ifdef __i386__
#define MNAMELEN 80 /* length of buffer for returned name */
+ #endif
+ #ifdef __alpha__
+ #define MNAMELEN 72 /* length of buffer for returned name */
+ #endif
struct statfs {
long f_spare2; /* placeholder */
Thanks!
Drew
------------------------------------------------------------------------------
Andrew Gallatin, Sr Systems Programmer http://www.cs.duke.edu/~gallatin
Duke University Email: gallatin@cs.duke.edu
Department of Computer Science Phone: (919) 660-6590
Sorry for the slow response. Because of the huge mail volume on
freebsd.org, I only rarely look at it. Better to send me mail at
mckusick@mckusick.com if you need a quick response.
I concur with your proposed change to maintain compatibility on
the alpha. Sorry for the breakage. Obviously I don't pay enough
attention to that architecture.
Kirk McKusick
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199912030021.QAA50864>