Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 9 Apr 2008 08:57:11 +0000
From:      Alexey Dokuchaev <danfe@FreeBSD.org>
To:        Marcel Moolenaar <xcllnt@mac.com>
Cc:        freebsd-ppc@FreeBSD.org
Subject:   Re: BMAC Ethernet Driver
Message-ID:  <20080409085711.GA14998@FreeBSD.org>
In-Reply-To: <CA0871A0-FE0D-4E5D-B1FB-8336D594341B@mac.com>
References:  <CB59240D-E385-4D4C-9372-E9D418502F61@mac.com> <EB224547-BCC9-4467-98E5-1D8EC0352349@mac.com> <Pine.GSO.4.62.0804022152590.20081@harper.uchicago.edu> <C1AB89FF-C466-46B0-BA83-2AD2989E73F9@mac.com> <47F4E007.90802@uchicago.edu> <3B02E59E-5399-40B6-9747-2F49200FD708@mac.com> <47F59C13.9030705@uchicago.edu> <20080404061224.GB11845@FreeBSD.org> <47FC0F9B.6070902@uchicago.edu> <CA0871A0-FE0D-4E5D-B1FB-8336D594341B@mac.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Apr 08, 2008 at 07:16:06PM -0700, Marcel Moolenaar wrote:
> 
> On Apr 8, 2008, at 5:36 PM, Nathan Whitehorn wrote:
> 
> >Hmm. I was mostly just trying to match the style in the rest of  
> >macio.c. Is it a better idea in this circumstance to match style(9)  
> >or the existing code?
> 
> Existing code takes precedence, especially if the
> changes you're making are minimal. For extensive
> changes you could consider first to make the file
> style(9) compliant and then make the changes...

I second Marcel here.

./danfe



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080409085711.GA14998>