Date: Tue, 28 Nov 2017 13:32:05 -0600 From: Bryan Venteicher <bryanv@daemoninthecloset.org> To: Lewis Donzis <lew@perftech.com> Cc: "freebsd-net@freebsd.org" <freebsd-net@freebsd.org> Subject: Re: vmxnet3 driver bug? Message-ID: <CAMo0n6RzTHDZU=NZoW6w%2B6-iPFfH5LxvrXrXP41h_M8Sq8Xi=w@mail.gmail.com> In-Reply-To: <0536294F-3709-4E38-AD7C-1A809AAD13A6@perftech.com> References: <398971232.399523.1508250252244.JavaMail.zimbra@perftech.com> <0536294F-3709-4E38-AD7C-1A809AAD13A6@perftech.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Oct 17, 2017 at 9:36 AM, Lewis Donzis <lew@perftech.com> wrote: > The VMXNET3 driver appears to have a bug that prevents it from correctly > reporting when the link goes down. > > There are two lines of code that should be deleted in > /usr/src/sys/dev/vmware/vmxnet3/if_vmx.c: > > @@ -3619,8 +3619,6 @@ vmxnet3_media_status(struct ifnet *ifp, struct > ifmediareq *ifmr) > VMXNET3_CORE_LOCK(sc); > if (vmxnet3_link_is_up(sc) !=3D 0) > ifmr->ifm_status |=3D IFM_ACTIVE; > - else > - ifmr->ifm_status |=3D IFM_NONE; > VMXNET3_CORE_UNLOCK(sc); > } > > IFM_NONE doesn=E2=80=99t belong in the status flags and, coincidentally, = is > defined with an identical value as IFM_ACTIVE, so it indicates that link = is > always active. > > This should be fixed in r326309 that I'll merge to the stable branches in a week. > Thanks, > lew > _______________________________________________ > freebsd-net@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-net > To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org"
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAMo0n6RzTHDZU=NZoW6w%2B6-iPFfH5LxvrXrXP41h_M8Sq8Xi=w>