Date: Thu, 11 Feb 2016 09:15:16 +0000 From: David Malone <dwmalone@maths.tcd.ie> To: Stefan Esser <se@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r295465 - head/usr.sbin/services_mkdb Message-ID: <20160211091516.GA37735@walton.maths.tcd.ie> In-Reply-To: <201602100940.u1A9ejb6086175@repo.freebsd.org> References: <201602100940.u1A9ejb6086175@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Feb 10, 2016 at 09:40:45AM +0000, Stefan Esser wrote: > Author: se > Date: Wed Feb 10 09:40:45 2016 > New Revision: 295465 > URL: https://svnweb.freebsd.org/changeset/base/295465 > > Log: > Remove O_SYNC from the options passed to dbmopen(). > > The services db is created as a temporary file that is moved over the > existing file after completion. Thus there is no need to immediately > flush all created db records to the temporary file. This was changed to fix a problem with fsync not being called, which can leave the db files empty after a sudden reboot. O_SYNC is not the right fix, but I think I've found the real problem and there is an open phabricator report on this, which fixes the problem in a better way: https://reviews.freebsd.org/D5186 Reviews appreciated. David.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20160211091516.GA37735>