Date: Wed, 8 Mar 2023 15:38:31 -0800 From: Warner Losh <imp@bsdimp.com> To: John Baldwin <jhb@freebsd.org> Cc: Ed Maste <emaste@freebsd.org>, src-committers <src-committers@freebsd.org>, "<dev-commits-src-all@freebsd.org>" <dev-commits-src-all@freebsd.org>, dev-commits-src-main@freebsd.org Subject: Re: git: c581962414ed - main - src.conf.5: Add some WITH_/WITHOUT_ option descriptions Message-ID: <CANCZdfoGi_R7B0ZK8si-zQT7SZ%2BahB7bvgRwFpcuRKdUfrZKvA@mail.gmail.com> In-Reply-To: <dac0dcf2-a104-e326-43ae-91a084b61623@FreeBSD.org> References: <202303082331.328NViDn050541@gitrepo.freebsd.org> <dac0dcf2-a104-e326-43ae-91a084b61623@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--00000000000043bae405f66c0705 Content-Type: text/plain; charset="UTF-8" On Wed, Mar 8, 2023, 3:34 PM John Baldwin <jhb@freebsd.org> wrote: > On 3/8/23 3:31 PM, Ed Maste wrote: > > The branch main has been updated by emaste: > > > > URL: > https://cgit.FreeBSD.org/src/commit/?id=c581962414edfc26796319ccc988647b08b03ce1 > > > > commit c581962414edfc26796319ccc988647b08b03ce1 > > Author: Ed Maste <emaste@FreeBSD.org> > > AuthorDate: 2023-03-07 18:49:23 +0000 > > Commit: Ed Maste <emaste@FreeBSD.org> > > CommitDate: 2023-03-08 23:30:45 +0000 > > > > src.conf.5: Add some WITH_/WITHOUT_ option descriptions > > > > Reviewed by: markj, brooks > > Sponsored by: The FreeBSD Foundation > > Differential Revision: https://reviews.freebsd.org/D38961 > > Hah, I was just working on those, but I noticed that we don't have > duplicate WITH/WITHOUT options for other options so kind of punted. > > The description for WITHOUT_OFED can be slightly simplified to use > the "Do not build..." pattern which is the more common idiom btw. > I've always wondered why we need both... can't we just have a generic description? Warner > --00000000000043bae405f66c0705 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"auto"><div><br><br><div class=3D"gmail_quote"><div dir=3D"ltr" = class=3D"gmail_attr">On Wed, Mar 8, 2023, 3:34 PM John Baldwin <<a href= =3D"mailto:jhb@freebsd.org">jhb@freebsd.org</a>> wrote:<br></div><blockq= uote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc = solid;padding-left:1ex">On 3/8/23 3:31 PM, Ed Maste wrote:<br> > The branch main has been updated by emaste:<br> > <br> > URL: <a href=3D"https://cgit.FreeBSD.org/src/commit/?id=3Dc581962414ed= fc26796319ccc988647b08b03ce1" rel=3D"noreferrer noreferrer" target=3D"_blan= k">https://cgit.FreeBSD.org/src/commit/?id=3Dc581962414edfc26796319ccc98864= 7b08b03ce1</a><br> > <br> > commit c581962414edfc26796319ccc988647b08b03ce1<br> > Author:=C2=A0 =C2=A0 =C2=A0Ed Maste <emaste@FreeBSD.org><br> > AuthorDate: 2023-03-07 18:49:23 +0000<br> > Commit:=C2=A0 =C2=A0 =C2=A0Ed Maste <emaste@FreeBSD.org><br> > CommitDate: 2023-03-08 23:30:45 +0000<br> > <br> >=C2=A0 =C2=A0 =C2=A0 src.conf.5: Add some WITH_/WITHOUT_ option descrip= tions<br> >=C2=A0 =C2=A0 =C2=A0 <br> >=C2=A0 =C2=A0 =C2=A0 Reviewed by:=C2=A0 =C2=A0 markj, brooks<br> >=C2=A0 =C2=A0 =C2=A0 Sponsored by:=C2=A0 =C2=A0The FreeBSD Foundation<b= r> >=C2=A0 =C2=A0 =C2=A0 Differential Revision: <a href=3D"https://reviews.= freebsd.org/D38961" rel=3D"noreferrer noreferrer" target=3D"_blank">https:/= /reviews.freebsd.org/D38961</a><br> <br> Hah, I was just working on those, but I noticed that we don't have<br> duplicate WITH/WITHOUT options for other options so kind of punted.<br> <br> The description for WITHOUT_OFED can be slightly simplified to use<br> the "Do not build..." pattern which is the more common idiom btw.= <br></blockquote></div></div><div dir=3D"auto"><br></div><div dir=3D"auto">= I've always wondered why we need both... can't we just have a gener= ic description?</div><div dir=3D"auto"><br></div><div dir=3D"auto">Warner</= div><div dir=3D"auto"><div class=3D"gmail_quote"><blockquote class=3D"gmail= _quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:= 1ex"> </blockquote></div></div></div> --00000000000043bae405f66c0705--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfoGi_R7B0ZK8si-zQT7SZ%2BahB7bvgRwFpcuRKdUfrZKvA>