Date: Mon, 25 May 2026 09:30:36 +0200 From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@FreeBSD.org> To: Jilles Tjoelker <jilles@stack.nl> Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 1df431576f99 - main - sh/tests: Cut down builtins/read12.0 by 2 seconds Message-ID: <865x4c2bfn.fsf@ltc.des.dev> In-Reply-To: <ahNUTRyxNE3AdPeW@stack.nl> (Jilles Tjoelker's message of "Sun, 24 May 2026 21:41:01 %2B0200") References: <6a120625.45836.5e8588e2@gitrepo.freebsd.org> <86h5nx3e8b.fsf@ltc.des.dev> <ahNUTRyxNE3AdPeW@stack.nl>
index | next in thread | previous in thread | raw e-mail
Jilles Tjoelker <jilles@stack.nl> writes: > Dag-Erling Smørgrav <des@FreeBSD.org> writes: > > Please revert the non-functional parts of this change. > Please explain what you are worried about in the change. Is this about > false positives or false negatives? The purpose of a test is to reliably fail if the functionality it tests is broken. Your change turns my test from one that is fairly certain to fail if the timeout functionality is broken to one that has a reasonable chance of passing regardless. What's more, you justify the change with a logical argument so fallacious that you _still_ refuse to explain it. All that just to save yourself a couple of seconds once in a while, even after I showed you how to save much more than two seconds simply by enabling parallelism. Please revert, or I will. DES -- Dag-Erling Smørgrav - des@FreeBSD.orghome | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?865x4c2bfn.fsf>