Date: Wed, 4 Dec 2002 22:53:21 -0800 (PST) From: Marcel Moolenaar <marcel@FreeBSD.org> To: Perforce Change Reviews <perforce@freebsd.org> Subject: PERFORCE change 21956 for review Message-ID: <200212050653.gB56rLCf007418@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=21956 Change 21956 by marcel@marcel_nfs on 2002/12/04 22:52:51 When the address hint is non-zero and we don't have the RSDP at the given address, bail out. Don't revert to scanning. The Itanium prototype has both ACPI1 and ACPI2 tables, but the ACPI1 RSDP is bogus -> *hang* We seem to be dereferencing a null pointer on the Itanium box. Something's not quite right... Affected files ... .. //depot/projects/ia64/usr.sbin/acpi/acpidump/acpi_user.c#5 edit Differences ... ==== //depot/projects/ia64/usr.sbin/acpi/acpidump/acpi_user.c#5 (text+ko) ==== @@ -113,6 +113,9 @@ return (acpi_map_physical(hint, sizeof(struct ACPIrsdp))); } notrsd: + if (hint != 0) + errx(1, "ACPI root pointer not at 0x%lx", hint); + for (i = 0; i < 1024 * 1024; i += 16) { pread(acpi_mem_fd, buf, 16, i); if (!memcmp(buf, "RSD PTR ", 8)) { To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe p4-projects" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200212050653.gB56rLCf007418>