Date: Sun, 6 Dec 2009 23:26:50 GMT From: Alexander Motin <mav@FreeBSD.org> To: Perforce Change Reviews <perforce@freebsd.org> Subject: PERFORCE change 171474 for review Message-ID: <200912062326.nB6NQoVv094287@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
http://p4web.freebsd.org/chv.cgi?CH=171474 Change 171474 by mav@mav_mavtest on 2009/12/06 23:25:51 Be more polite to freeze underruns in production. It is bad, but not fatal. Affected files ... .. //depot/projects/scottl-camlock/src/sys/cam/cam_xpt.c#133 edit Differences ... ==== //depot/projects/scottl-camlock/src/sys/cam/cam_xpt.c#133 (text+ko) ==== @@ -4152,7 +4152,10 @@ KASSERT(count <= dev->ccbq.queue.qfrozen_cnt, ("xpt_release_devq: requested %u > present %u\n", count, dev->ccbq.queue.qfrozen_cnt)); - dev->ccbq.queue.qfrozen_cnt -= count; + if (count <= dev->ccbq.queue.qfrozen_cnt) + dev->ccbq.queue.qfrozen_cnt -= count; + else + dev->ccbq.queue.qfrozen_cnt = 0; if (dev->ccbq.queue.qfrozen_cnt == 0) { /* * No longer need to wait for a successful @@ -4190,7 +4193,8 @@ KASSERT(sendq->qfrozen_cnt > 0, ("xpt_release_simq: requested 1 > present %u\n", sendq->qfrozen_cnt)); - sendq->qfrozen_cnt--; + if (sendq->qfrozen_cnt > 0) + sendq->qfrozen_cnt--; if (sendq->qfrozen_cnt == 0) { /* * If there is a timeout scheduled to release this
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200912062326.nB6NQoVv094287>