Date: Mon, 27 Jun 2005 18:21:55 +0300 From: Ruslan Ermilov <ru@FreeBSD.org> To: Gleb Smirnoff <glebius@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/netinet/libalias alias_ftp.c alias_irc.c alias_local.h alias_proxy.c alias_skinny.c alias_smedia.c alias_util.c Message-ID: <20050627152155.GF93072@ip.net.ua> In-Reply-To: <200506270736.j5R7a3OZ036531@repoman.freebsd.org> References: <200506270736.j5R7a3OZ036531@repoman.freebsd.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Mon, Jun 27, 2005 at 07:36:02AM +0000, Gleb Smirnoff wrote: > glebius 2005-06-27 07:36:02 UTC > > FreeBSD src repository > > Modified files: > sys/netinet/libalias alias_ftp.c alias_irc.c alias_local.h > alias_proxy.c alias_skinny.c > alias_smedia.c alias_util.c > Log: > Disable checksum processing in LibAlias, when it works as a > kernel module. LibAlias is not aware about checksum offloading, > so the caller should provide checksum calculation. (The only > current consumer is ng_nat(4)). When TCP packet internals has > been changed and it requires checksum recalculation, a cookie > is set in th_x2 field of TCP packet, to inform caller that it > needs to recalculate checksum. This ugly hack would be removed > when LibAlias is made more kernel friendly. > > Incremental checksum updates are left as is, since they don't > conflict with offloading. > > Approved by: re (scottl) > > Revision Changes Path > 1.27 +4 -0 src/sys/netinet/libalias/alias_ftp.c > 1.21 +4 -0 src/sys/netinet/libalias/alias_irc.c > 1.32 +10 -1 src/sys/netinet/libalias/alias_local.h > 1.26 +4 -0 src/sys/netinet/libalias/alias_proxy.c > 1.12 +12 -2 src/sys/netinet/libalias/alias_skinny.c > 1.15 +8 -1 src/sys/netinet/libalias/alias_smedia.c > 1.18 +8 -8 src/sys/netinet/libalias/alias_util.c > Why can't we just say that checksum offloading is incompatible with NAT (like with many other things), and do the software checksum calculations in libalias? Cheers, -- Ruslan Ermilov ru@FreeBSD.org FreeBSD committer [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.1 (FreeBSD) iD8DBQFCwBmTqRfpzJluFF4RArbfAKCVcS3phO9RBO6k7l7qrifnQp3CBwCfWQLn k6MsbxNmsCIDZzZq2Caxtzo= =556N -----END PGP SIGNATURE-----help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050627152155.GF93072>