Date: Thu, 18 Dec 2014 15:59:02 -0800 From: Steve Kargl <sgk@troutmask.apl.washington.edu> To: Warner Losh <wlosh@netflix.com> Cc: Ed Schouten <ed@80386.nl>, src-committers@freebsd.org, svn-src-all@freebsd.org, Dimitry Andric <dim@FreeBSD.org>, svn-src-head@freebsd.org, Garrett Cooper <yaneurabeya@gmail.com> Subject: Re: svn commit: r275819 - in head/lib/msun: ld128 ld80 src Message-ID: <20141218235902.GA1590@troutmask.apl.washington.edu> In-Reply-To: <18504F2A-72C1-4962-86E6-CCAE4898B478@gmail.com> References: <201412160921.sBG9LvFY064961@svn.freebsd.org> <20141216162055.GA64273@troutmask.apl.washington.edu> <CAJOYFBAAe_3psxdDC1Oq0%2BW=9T4qnSDK=tST3pP6q1iBpgME1w@mail.gmail.com> <20141217191235.GA89501@troutmask.apl.washington.edu> <87FF0FD4-EEF2-4264-9CBA-4B3A46E52FCB@gmail.com> <20141217211654.GA95193@troutmask.apl.washington.edu> <18504F2A-72C1-4962-86E6-CCAE4898B478@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Dec 18, 2014 at 02:44:47PM -0700, Warner Losh wrote: > > > On Dec 17, 2014, at 2:16 PM, Steve Kargl <sgk@troutmask.apl.washington.edu> wrote: > > > > > > Ed's diff is ~1000 lines and touches several files. Localizing > > the change to math_private.h would have been a ~20 line > > diff to a single file. > > Then just back his change out, put yours in and we all win. I had already written that I would not ask Ed to revert his change due to the excessive code churn. You may interpret this to mean that I will not unfix what was not needed to be fix to begin with. My only hope now is that Ed will fix the comment he inserted into math_private.h to properly note that the functions formerly known as cpack[fl] were written years before the C11 macros CMPLX[FL] existed. -- Steve
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20141218235902.GA1590>