Date: Wed, 2 Jan 2002 15:20:02 -0800 (PST) From: swear@blarg.net (Gary W. Swearingen) To: freebsd-doc@freebsd.org Subject: Re: docs/31265: crontab(1) doesn't decribe format of allow and deny files. Message-ID: <200201022320.g02NK2H82357@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR docs/31265; it has been noted by GNATS. From: swear@blarg.net (Gary W. Swearingen) To: Marc Silver <marcs@draenor.org> Cc: freebsd-gnats-submit@FreeBSD.org Subject: Re: docs/31265: crontab(1) doesn't decribe format of allow and deny files. Date: 02 Jan 2002 15:17:27 -0800 Marc Silver <marcs@draenor.org> writes: > On Tue, Jan 01, 2002 at 09:11:40PM -0800, Gary W. Swearingen wrote: > > [stuff at this level] > There's no testing error here... it works just fine for me. OK, so I re-tested too and find I still have the error. Shall we try to determine whether I've got old code or you've got a testing error or...? I find the newest file under /usr/src/usr.sbin/cron to be /usr/src/usr.sbin/cron/crontab/crontab.c dated Jun 15 2001; size 13933; md5 3d7a88f82812c75c7a1ab0d3d806dc86 My /usr/bin/crontab is size 24872, but I'm not sure if that SHOULD match yours. I cvsup'd "RELENG_4/src-all" 26'dec'01 and did "make world" stuff then. Running as "jojo", I get this with "jojo" at the end of "/var/cron/allow". $ crontab -l crontab: you (jojo) are not allowed to use this program $ hd /var/cron/allow | tail -2 00000370 20 72 6f 6f 74 2e 0a 72 6f 6f 74 0a 6a 6f 6a 6f | root..root.jojo| 00000380 > .. my unpatched crontab.1 file seemed different to yours, ... My /usr/src/usr.sbin/cron/crontab/crontab.1 and my 4.3R one both have 3282 Dec 8 2000 /usr/src/usr.sbin/cron/crontab/crontab.1 > > I think it's rather silly to say "you must use the correct format". > > You're entitled to your opinion. Do you have a better suggestion? Omit the sentence which contains it. It should go without saying. > Btw. Your reply seems somewhat agressive... if I've offended you by > submitting this, then I apologise. I despise aggressiveness and usually restrain myself, but I occasionally repay inferred offense with implied offense. This time I tried to merely state what I thought of your changes and not what I thought of your seeming carelessness in making them. I spent a long time carefully wording my patch. I would have reacted better to criticism and suggestions for improvement than to a flat-out replacement, especially when I find it to be both poorly expressed and inaccurate. Maybe this is a lesson to push one's PR on people after it gets ignored. You were kind enough to ask for my thoughts on a rewrite. Here they are. Please don't take offense. +In order to use the +.Pa allow +and +.Pa deny +files the following format must be adhered to: +.Pp +.Bl -tag -width indent +.It Fl +Only one username may be added per line. Verbose. And the last line sounds strange. Sorry I can't explain it well; something strange about adding to a line which doesn't exist. How about replacing all with: "In these files, each user name must be on a separate line with no other characters on the line. Other lines are ignored and may be used for comments. A bug in the program causes a user name at the end of the file to be ignored; end the file with a newline character to avoid the bug." (The last part depending on what our research shows.) +.It Fl +The username should not have any characters (such as whitespace) +preceding it or it will be ignored. Preceding AND FOLLOWING IT ON THE SAME LINE. (Depending on research.) +.It Fl +The username must start at the beginning of a line. (^) Redundant. The previous sentence has the same meaning. +.It Fl +Anything else will be ignored as a comment. Anything else than what? Will a "#..." after the user name be ignored as a comment? Yes, but so will the user name. +.El +.Bl -tag -width indent +.Pp +If neither of these files exists, then depending on site-dependent +configuration parameters, only the super user will be allowed to use +this command, or all users will be able to use this command. I had left that for another PR, but that leaves one asking: What configuration parameters? Please send me date/size/md5 info as I did above or any other ideas you might have on determining whether I have old software or why we get different testing results. (I also checked misc.c and crontab.c in http://www.freebsd.org/cgi/cvsweb.cgi/src/usr.sbin/cron/ and it seems I've got current code for RELENG_4.) Oh, I tested by simply editing "allow" and running "crontab -l" as a normal user. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-doc" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200201022320.g02NK2H82357>