Date: Mon, 30 Jan 2006 23:43:20 GMT From: Robert Watson <rwatson@FreeBSD.org> To: Perforce Change Reviews <perforce@freebsd.org> Subject: PERFORCE change 90742 for review Message-ID: <200601302343.k0UNhKL3068479@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=90742 Change 90742 by rwatson@rwatson_zoo on 2006/01/30 23:42:19 Audit vnode information in fstatfs() after acquiring Giant, not before. Affected files ... .. //depot/projects/trustedbsd/audit3/sys/kern/vfs_syscalls.c#21 edit Differences ... ==== //depot/projects/trustedbsd/audit3/sys/kern/vfs_syscalls.c#21 (text+ko) ==== @@ -329,17 +329,16 @@ if (error) return (error); + mp = fp->f_vnode->v_mount; + fdrop(fp, td); + if (mp == NULL) + return (EBADF); + mtx_lock(&Giant); #ifdef AUDIT vn_lock(fp->f_vnode, LK_EXCLUSIVE | LK_RETRY, td); AUDIT_ARG(vnode, fp->f_vnode, ARG_VNODE1); VOP_UNLOCK(fp->f_vnode, 0, td); #endif - - mp = fp->f_vnode->v_mount; - fdrop(fp, td); - if (mp == NULL) - return (EBADF); - mtx_lock(&Giant); #ifdef MAC error = mac_check_mount_stat(td->td_ucred, mp); if (error) {
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200601302343.k0UNhKL3068479>