Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 14 Aug 2018 14:50:07 +0000 (UTC)
From:      Mark Johnston <markj@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r337758 - head/sys/x86/x86
Message-ID:  <201808141450.w7EEo78r029739@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: markj
Date: Tue Aug 14 14:50:06 2018
New Revision: 337758
URL: https://svnweb.freebsd.org/changeset/base/337758

Log:
  Explain why we aren't using memcpy().
  
  Reported by:	jmg
  X-MFC with:	r337715
  Sponsored by:	The FreeBSD Foundation

Modified:
  head/sys/x86/x86/ucode.c

Modified: head/sys/x86/x86/ucode.c
==============================================================================
--- head/sys/x86/x86/ucode.c	Tue Aug 14 14:19:57 2018	(r337757)
+++ head/sys/x86/x86/ucode.c	Tue Aug 14 14:50:06 2018	(r337758)
@@ -344,6 +344,7 @@ ucode_load_bsp(uintptr_t free)
 		match = loader->match(fileaddr, &len);
 		if (match != NULL) {
 			addr = map_ucode(free, len);
+			/* We can't use memcpy() before ifunc resolution. */
 			for (i = 0; i < len; i++)
 				addr[i] = match[i];
 			match = addr;



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201808141450.w7EEo78r029739>