Date: Mon, 03 Feb 2003 13:51:59 -0700 (MST) From: "M. Warner Losh" <imp@bsdimp.com> To: myevmenk@exodus.net Cc: hackers@FreeBSD.ORG, questions@FreeBSD.ORG, brian@FreeBSD.ORG, doconnor@gsoft.com.au Subject: Re: [PATCH] PPP in -direct mode does not execute any chat scripts Message-ID: <20030203.135159.94296629.imp@bsdimp.com> In-Reply-To: <3E3ED4DF.7090904@exodus.net> References: <45258A4365C6B24A9832BFE224837D552B1283@sjdcex01.int.exodus.net> <3E3ED4DF.7090904@exodus.net>
next in thread | previous in thread | raw e-mail | index | archive | help
In message: <3E3ED4DF.7090904@exodus.net>
Maksim Yevmenkin <myevmenk@exodus.net> writes:
: Dear Hackers,
:
: Please find attached patch that adds new option to the PPP.
:
:
: run-scripts-in-direct-mode
: Default: Disabled. This allows to run chat scripts in
: direct mode.
:
: did i miss anything? objections? comments? reviews?
Maybe it would be better to call this "force-scripts" or something
more general purpose so that one could force the use of scripts
anywhere. Making direct mode have a special case override seems a
little too restrictive. The heart of the patch would become:
- if (dl->physical->type & (PHYS_DIRECT|PHYS_DEDICATED))
+ if (!Enabled(dl->bundle, OPT_FORCE_SCRIPTS) &&
+ (dl->physical->type & (PHYS_DIRECT|PHYS_DEDICATED))
/* Ignore scripts */
runscripts = 0;
with corresponding changes to the docs, defines, etc.
Warner
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-questions" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030203.135159.94296629.imp>