Date: Tue, 26 Feb 2013 13:35:30 -0500 From: John Baldwin <jhb@freebsd.org> To: Davide Italiano <davide@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Xin LI <delphij@freebsd.org> Subject: Re: svn commit: r247300 - in head: sys/sys usr.bin/truss Message-ID: <201302261335.38001.jhb@freebsd.org> In-Reply-To: <CACYV=-E2LddT1jmjvFTLsq_NymbxrEvHL9w4SCOZaVhGGy2p=Q@mail.gmail.com> References: <201302260213.r1Q2D2N1016801@svn.freebsd.org> <201302260941.52534.jhb@freebsd.org> <CACYV=-E2LddT1jmjvFTLsq_NymbxrEvHL9w4SCOZaVhGGy2p=Q@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tuesday, February 26, 2013 12:09:42 pm Davide Italiano wrote: > On Tue, Feb 26, 2013 at 3:41 PM, John Baldwin <jhb@freebsd.org> wrote: > > On Monday, February 25, 2013 9:13:02 pm Xin LI wrote: > >> Author: delphij > >> Date: Tue Feb 26 02:13:02 2013 > >> New Revision: 247300 > >> URL: http://svnweb.freebsd.org/changeset/base/247300 > >> > >> Log: > >> Expose timespec and timeval macros when __BSD_VISIBLE is defined. This > >> allows userland application to use the following macros: > >> > >> timespecclear, timespecisset, timespeccmp, timespecadd, > >> timespecsub; > >> > >> timevalclear, timevalisset, timevalcmp. > > > > Why not fix truss to use the stock functions instead of keeping private > > "unusual" versions? > > > > -- > > John Baldwin > > time.h is already a mess in terms of namespace pollution, and this > exposure might not help thing. > Other details here: > http://permalink.gmane.org/gmane.os.freebsd.architechture/15518 I think that is orthogonal. Even if this is reverted I think truss should be changed to use the "normal" timespecsubt() macro rather than using a custom one with a different argument order. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201302261335.38001.jhb>