Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 30 Jun 2026 16:52:04 +0000
From:      Kyle Evans <kevans@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: cb8bda40695f - main - evdev: use a prometheus-safe label for ev_sysctl_tree
Message-ID:  <6a43f434.40740.34cd897a@gitrepo.freebsd.org>

index | next in thread | raw e-mail

The branch main has been updated by kevans:

URL: https://cgit.FreeBSD.org/src/commit/?id=cb8bda40695f5d402f334f48795b1ab27b72dce5

commit cb8bda40695f5d402f334f48795b1ab27b72dce5
Author:     Kyle Evans <kevans@FreeBSD.org>
AuthorDate: 2026-06-30 16:51:57 +0000
Commit:     Kyle Evans <kevans@FreeBSD.org>
CommitDate: 2026-06-30 16:51:57 +0000

    evdev: use a prometheus-safe label for ev_sysctl_tree
    
    Prometheus doesn't allow spaces, let's normalize this to what we use
    elsewhere for consistency.  The sysctl exporter could probably do this
    itself, but let's decouple that from the immediate problem: matching the
    label between the exported data and in-tree is nice for greppability.
    
    PR:             296179
    Reviewed by:    asomers, wulf
    Differential Revision:  https://reviews.freebsd.org/D57966
---
 sys/dev/evdev/evdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sys/dev/evdev/evdev.c b/sys/dev/evdev/evdev.c
index b8628d570a3c..20244333f1f8 100644
--- a/sys/dev/evdev/evdev.c
+++ b/sys/dev/evdev/evdev.c
@@ -215,7 +215,7 @@ evdev_sysctl_create(struct evdev_dev *evdev)
 	ev_sysctl_tree = SYSCTL_ADD_NODE_WITH_LABEL(&evdev->ev_sysctl_ctx,
 	    SYSCTL_STATIC_CHILDREN(_kern_evdev_input), OID_AUTO,
 	    ev_unit_str, CTLFLAG_RD | CTLFLAG_MPSAFE, NULL, "",
-	    "device index");
+	    "device_index");
 
 	SYSCTL_ADD_STRING(&evdev->ev_sysctl_ctx,
 	    SYSCTL_CHILDREN(ev_sysctl_tree), OID_AUTO, "name", CTLFLAG_RD,


home | help

Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?6a43f434.40740.34cd897a>