Date: Thu, 25 Sep 2014 10:47:57 -0500 From: Bryan Drewery <bdrewery@FreeBSD.org> To: freebsd-arch@freebsd.org Subject: Re: KASSERT_WARN for asserting malloc(M_WAITOK) not in a non-sleepable thread Message-ID: <5424392D.9030201@FreeBSD.org> In-Reply-To: <CACYV=-Eg69AQ72DOGppPSL7whJVCdcNg-auhBZ771iG7DfPdAw@mail.gmail.com> References: <54236CD6.4050807@FreeBSD.org> <CACYV=-Eg69AQ72DOGppPSL7whJVCdcNg-auhBZ771iG7DfPdAw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On 9/24/2014 9:56 PM, Davide Italiano wrote: > On Wed, Sep 24, 2014 at 6:16 PM, Bryan Drewery <bdrewery@freebsd.org> wrote: >> Hi, >> >> I've placed 2 reviews out in relation to >> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=193696: >> >> Add KASSERT_WARN which will work just like KASSERT except that no panic >> will occur. My own expectation would be that any use of it would >> eventually be promoted to a full KASSERT. It would only be used where >> the impact is not known yet on all hardware/devices. We don't want to >> go adding a KASSERT and break boot for a whole class of systems. >> >> https://reviews.freebsd.org/D829 - KASSERT_WARN >> > > FYI, I'm not excited about the idea. If you introduce an assert you > want some invariant to not be violated. If it's violated, there's > something clearly going wrong and you need to stop and think about it. > I guess that in most cases is just better fail early, rather than keep > going with the system in a semi-functional state. Also, please note > that once a KPI is introduced in the kernel, everybody may start > abusing it. > A previous attempt (in my opinion wrong) was made to have KASSERT to > log rather than panic. It actually didn't lead to any benefit, > apparently. FWIW, at least your approach is more fine grained. > > -- > Davide I would be comfortable adding it in as a full KASSERT (and not bringing in KASSERT_WARN) if other people test the patch in https://reviews.freebsd.org/D830 and change them to KASSERT. If the fallout is not too bad then we can commit the real assert. -- Regards, Bryan Drewery [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (MingW32) iQEcBAEBAgAGBQJUJDktAAoJEDXXcbtuRpfPjRwH/3IoiP7zk2EjJIVvHwoP403z zZkRZmGOvu9Fd2uMH3+Nx042RI1TXLMtoKvrorPo94nLmYRyusj15VMqwY+SWKGc AgQlULUC5Q9UWRaOS4W1zp4OtM4URYO2nvN3pY3IYDbGhc620nnN72GUDFUKsYKr w8WX9jxK4r1vEKksNG919DjBOjS821XxOSmgfQlBS3W4lmMVIfRCCZTfLUeUJWIA 1DJFOxLzy9bFqzLqOoLE1MLrwigung4gKdGXzd37ioFK63DR5assZHTJ05Znx0cw EySgX2vRkHiIy4G5R/+FBn2C7rwr3lAf4sDGSzt1TjN9okwEIhkpyelOHju9DgU= =Xy6B -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5424392D.9030201>