Date: Mon, 20 Feb 2006 20:36:30 -0800 From: Julian Elischer <julian@elischer.org> To: Greg 'groggy' Lehey <grog@FreeBSD.org> Cc: cvs-src@FreeBSD.org, Andrew Gallatin <gallatin@FreeBSD.org>, cvs-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: cvs commit: src/sys/modules Makefile Message-ID: <43FA98CE.3010000@elischer.org> In-Reply-To: <20060220224724.GJ65002@wantadilla.lemis.com> References: <200602200250.k1K2o9WQ060573@repoman.freebsd.org> <20060220224724.GJ65002@wantadilla.lemis.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Greg 'groggy' Lehey wrote: >On Monday, 20 February 2006 at 2:50:09 +0000, Andrew Gallatin wrote: > > >>gallatin 2006-02-20 02:50:09 UTC >> >> FreeBSD src repository >> >> Modified files: >> sys/modules Makefile >> Log: >> Hook the myri10ge driver to the i386 and amd64 module builds. >> >> > >Is this device really going to be called myri10ge? That's at least >double the length of any other device. Can't we come up with a >shorter name? > > not to mention that in divert(4) we store the interface in the 8 char area of a sockaddr_in that is left over after everything else is filled in we only have the 8 bytes of the zero section so hide this info, so the 8 bytes name given here is right on the edge, and I don't know if it is all tested for null termination requirements. >Greg >-- >See complete headers for address and phone numbers. > >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?43FA98CE.3010000>