Date: Thu, 05 Oct 2017 15:13:46 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 222779] New port: emulators/mgba, a Game Boy Advance emulator Message-ID: <bug-222779-13-EKYXdWAWoj@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-222779-13@https.bugs.freebsd.org/bugzilla/> References: <bug-222779-13@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D222779 Tobias Kortkamp <tobik@freebsd.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tobik@freebsd.org --- Comment #1 from Tobias Kortkamp <tobik@freebsd.org> --- +.include <bsd.port.options.mk> + +.if ${PORT_OPTIONS:MDEBUGGERS} +USES+=3D libedit +.endif + +.if ${PORT_OPTIONS:MQT} +USE_QT5=3D qmake_build buildtools_build core gui widgets net= work opengl multimedia +USES+=3D desktop-file-utils +INSTALLS_ICONS=3D yes +.endif Hmm, all of these variables are settable via options helpers. I don't understand why you stopped using them here. +LDFLAGS+=3D -L/usr/local/lib # sqlite3 Using /usr/local directly like this is not correct (LOCALBASE can be set to other values by users). Use ${LOCALBASE} instead or better yet replace the whole thing by adding localbase:ldflags to USES +FFMPEG_DESC=3D FFmpeg video recording support +MAGICK_DESC=3D ImageMagick GIF recording support +QT_DESC=3D Qt frontend Please move all custom descriptions to after the OPTIONS_* section followed= by a section for the options helpers. Maybe rename QT->QT5. FFMPEG, MAGICK, QT5 already have descriptions in bsd.options.desc.mk. Do you need custom descriptions? https://www.freebsd.org/doc/en/books/porters-handbook/book.html#porting-ord= er-options --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-222779-13-EKYXdWAWoj>