Skip site navigation (1)Skip section navigation (2) 
Date:      Sat, 2 Aug 2025 14:42:22 +0200
From:      Daniel Engberg <diizzy@FreeBSD.org>
To:        =?UTF-8?B?w4RsdmVu?= <alven@FreeBSD.org>, ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org, Yuri Victorovich <yuri@FreeBSD.org>
Subject:   Re: git: ce3687b1f659 - main - sysutils/sensors: new port, show sensors/temperatures info
Message-ID:  <4886f340-f6ca-4ece-96d8-786294d6f925@FreeBSD.org>
In-Reply-To: <202508021153.572Br6vS087363@gitrepo.freebsd.org>
index | next in thread | previous in thread | raw e-mail 

[-- Attachment #1 --]
On 2025-08-02 13:53, Älven wrote:
> The branch main has been updated by alven:
>
> URL:https://cgit.FreeBSD.org/ports/commit/?id=ce3687b1f6590796c17405040d70fdf6f4977e9f
>
> commit ce3687b1f6590796c17405040d70fdf6f4977e9f
> Author:     Älven<alven@FreeBSD.org>
> AuthorDate: 2025-08-02 11:46:40 +0000
> Commit:     Älven<alven@FreeBSD.org>
> CommitDate: 2025-08-02 11:52:36 +0000
>
>      sysutils/sensors: new port, show sensors/temperatures info
>      
>      The sensors(8) tools shows temperatures and sensors info on FreeBSD UNIX systems.
>      
>      More details here:
>      -https://github.com/vermaden/sensors
>      -https://vermaden.wordpress.com/2022/02/15/sensors-information-on-freebsd/
>      
>      PR:             288500
>      Approved by:    yuri@ (Mentor)
> ...
> --- /dev/null
> +++ b/sysutils/sensors/distinfo
> @@ -0,0 +1,5 @@
> +TIMESTAMP = 1753639972
> +SHA256 (sensors/sensors-0.6.tar.gz) = 6304f7f6da342c1a856deebb16784437d6a7001e027c1fab6be38d238a5f5b55
> +SIZE (sensors/sensors-0.6.tar.gz) = 3257
> +SHA256 (sensors/LICENSE) = b4bb8570bcaaf370e936763a1cf5dade6994c8fceb93bff22c9b768b8184f14f
> +SIZE (sensors/LICENSE) = 1356

Hi,

Yuri, can you please review more carefully?

This will cause clashes because LICENSE is unversioned. Given that 
submitter is maintainer why not ask to fix the repo (use tags and don't 
add binaries to repo) or create proper release assets?Best regards, Daniel

[-- Attachment #2 --]
<!DOCTYPE html>
<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
  </head>
  <body>
    <div class="moz-cite-prefix">On 2025-08-02 13:53, Älven wrote:<br>
    </div>
    <blockquote type="cite"
      cite="mid:202508021153.572Br6vS087363@gitrepo.freebsd.org">
      <pre wrap="" class="moz-quote-pre">The branch main has been updated by alven:

URL: <a class="moz-txt-link-freetext" href="https://cgit.FreeBSD.org/ports/commit/?id=ce3687b1f6590796c17405040d70fdf6f4977e9f">https://cgit.FreeBSD.org/ports/commit/?id=ce3687b1f6590796c17405040d70fdf6f4977e9f</a>;

commit ce3687b1f6590796c17405040d70fdf6f4977e9f
Author:     Älven <a class="moz-txt-link-rfc2396E" href="mailto:alven@FreeBSD.org">&lt;alven@FreeBSD.org&gt;</a>
AuthorDate: 2025-08-02 11:46:40 +0000
Commit:     Älven <a class="moz-txt-link-rfc2396E" href="mailto:alven@FreeBSD.org">&lt;alven@FreeBSD.org&gt;</a>
CommitDate: 2025-08-02 11:52:36 +0000

    sysutils/sensors: new port, show sensors/temperatures info
    
    The sensors(8) tools shows temperatures and sensors info on FreeBSD UNIX systems.
    
    More details here:
    - <a class="moz-txt-link-freetext" href="https://github.com/vermaden/sensors">https://github.com/vermaden/sensors</a>;
    - <a class="moz-txt-link-freetext" href="https://vermaden.wordpress.com/2022/02/15/sensors-information-on-freebsd/">https://vermaden.wordpress.com/2022/02/15/sensors-information-on-freebsd/</a>;
    
    PR:             288500
    Approved by:    yuri@ (Mentor)
...
--- /dev/null
+++ b/sysutils/sensors/distinfo
@@ -0,0 +1,5 @@
+TIMESTAMP = 1753639972
+SHA256 (sensors/sensors-0.6.tar.gz) = 6304f7f6da342c1a856deebb16784437d6a7001e027c1fab6be38d238a5f5b55
+SIZE (sensors/sensors-0.6.tar.gz) = 3257
+SHA256 (sensors/LICENSE) = b4bb8570bcaaf370e936763a1cf5dade6994c8fceb93bff22c9b768b8184f14f
+SIZE (sensors/LICENSE) = 1356</pre>
    </blockquote>
    <p>Hi,<br>
    </p>
    <p>Yuri, can you please review more carefully?</p>
    <p>This will cause clashes because LICENSE is
      unversioned. Given that submitter
      is maintainer why not ask to fix the repo (use tags and don't add
      binaries to repo) or create proper release assets?<span
      style="white-space: pre-wrap">

Best regards,
Daniel
</span></p>
  </body>
</html>
home | help

Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4886f340-f6ca-4ece-96d8-786294d6f925>