Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 20 Mar 2026 07:16:18 +0000
From:      Jake Freeland <jfree@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: 33345b883485 - main - timerfd: Suppress kqueue readability after jump read
Message-ID:  <69bcf442.3bfcc.7e4ee027@gitrepo.freebsd.org>

index | next in thread | raw e-mail

The branch main has been updated by jfree:

URL: https://cgit.FreeBSD.org/src/commit/?id=33345b8834859cf1ad7f1256f3a34b4a7c83e8e8

commit 33345b8834859cf1ad7f1256f3a34b4a7c83e8e8
Author:     Jake Freeland <jfree@FreeBSD.org>
AuthorDate: 2026-03-20 06:34:15 +0000
Commit:     Jake Freeland <jfree@FreeBSD.org>
CommitDate: 2026-03-20 07:15:09 +0000

    timerfd: Suppress kqueue readability after jump read
    
    Do not report EVFILT_READ after reading a discontinuous clock jump.
    This makes the kqueue filter consistent with Linux epoll behavior
    and timerfd_poll(), which already checks tfd_jumped != TFD_READ before
    reporting POLLIN.
    
    MFC after: 2 weeks
---
 sys/kern/sys_timerfd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sys/kern/sys_timerfd.c b/sys/kern/sys_timerfd.c
index e4d00f224505..22e6a30faa21 100644
--- a/sys/kern/sys_timerfd.c
+++ b/sys/kern/sys_timerfd.c
@@ -290,7 +290,7 @@ filt_timerfdread(struct knote *kn, long hint)
 
 	mtx_assert(&tfd->tfd_lock, MA_OWNED);
 	kn->kn_data = (int64_t)tfd->tfd_count;
-	return (tfd->tfd_count > 0);
+	return (tfd->tfd_count > 0 && tfd->tfd_jumped != TFD_READ);
 }
 
 static const struct filterops timerfd_rfiltops = {


home | help

Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?69bcf442.3bfcc.7e4ee027>