Date: Fri, 22 May 1998 21:25:09 +1000 From: Bruce Evans <bde@zeta.org.au> To: bde@zeta.org.au, current@FreeBSD.ORG, eivind@yes.no Subject: Re: cvs commit: src/sys/pci if_tl.c if_tlreg.h Message-ID: <199805221125.VAA23522@godzilla.zeta.org.au>
next in thread | raw e-mail | index | archive | help
>> >That was the change I installed and backed out so fast earlier today;
>> >it unfortunately didn't work.
>>
>> Fortunately :-).
>
>If you didn't want __FreeBSD_version moved to param.h, you had every chance
>to object when I sent the proposal to -current - it had a very clear subject
>("__FreeBSD_version -> param.h", I think). Right now that change is active
>in the tree (as I had time to fix it today).
I don't remember seeing it (and I think I see most things sent to
freebsd-current). Besides, you should know that I wouldn't like it :-).
I also objected to __FreeBSD__ and BSD (not the system, but the identifier
in <sys/param.h> :-).
>> It's a step backwards. We use cvs for version control here.
>
>We're talking external drivers. I'm in favour of removing all #ifdefs for
>versions/systems from the FreeBSD tree, as long as it can be done in an
>automated fashion before each new import (I'm not certain how well unifdef
>handles the task - I've not looked at it).
unifdef is not very suitable for anything except output to /dev/null. It
doesn't even understand `#if expression'.
Bruce
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199805221125.VAA23522>