Date: Mon, 28 Mar 2011 11:32:12 -0400 From: Ryan Stone <rysto32@gmail.com> To: Aleksandr Rybalko <ray@dlink.ua> Cc: "freebsd-current@freebsd.org" <freebsd-current@freebsd.org> Subject: Re: Fix softdep_request_cleanup difference w/ and w/o SOFTUPDATES Message-ID: <AANLkTinB20FEPrDrc4G6%2Bse_hmyKpzCAe5_9JHa0FH2N@mail.gmail.com> In-Reply-To: <20110328131903.6bf2bc62.ray@dlink.ua> References: <20110328131903.6bf2bc62.ray@dlink.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Mar 28, 2011 at 6:19 AM, Aleksandr Rybalko <ray@dlink.ua> wrote:
> Hi,
>
> I found a difference of definition softdep_request_cleanup.
> when SOFTUPDATES undefined softdep_request_cleanup take only two argument=
s.
>
> Patch to fix this:
>
> Index: sys/ufs/ffs/ffs_softdep.c
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> --- sys/ufs/ffs/ffs_softdep.c =A0 (revision 220095)
> +++ sys/ufs/ffs/ffs_softdep.c =A0 (working copy)
> @@ -514,9 +514,10 @@
> =A0}
>
> =A0int
> -softdep_request_cleanup(fs, vp)
> +softdep_request_cleanup(fs, vp, resource)
> =A0 =A0 =A0 =A0struct fs *fs;
> =A0 =A0 =A0 =A0struct vnode *vp;
> + =A0 =A0 =A0 int resource;
> =A0{
>
> =A0 =A0 =A0 =A0return (0);
If we need to change the definition, shouldn't we convert it to a C89
declaration at the same time?
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AANLkTinB20FEPrDrc4G6%2Bse_hmyKpzCAe5_9JHa0FH2N>