Date: Sun, 19 Jun 2022 00:20:27 +0000 From: "sunpoet (Po-Chuan Hsieh)" <phabric-noreply@FreeBSD.org> To: Phabricator <phabric-noreply@FreeBSD.org> Cc: freebsd-python@freebsd.org Subject: [Differential] D35513: [WIP] Adding devel/py-threadpoolctl Message-ID: <ddca27aa1cfb78570c60410997ff149c@localhost.localdomain> In-Reply-To: <differential-rev-PHID-DREV-gt2zo7osgqhg7babxfr3-req@reviews.freebsd.org> References: <differential-rev-PHID-DREV-gt2zo7osgqhg7babxfr3-req@reviews.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
sunpoet added inline comments.
INLINE COMMENTS
> koobs wrote in Makefile:32
> Upstream provides tests in their sources. If these are not packaged in the PyPI sdist, feel free to `USE_GITHUB` in the meantime after asking upstream to ship them there.
>
> Should be able to:
>
> do-test:
> cd ${WRKSRC} && ${PYTHON_CMD} -m pytest -v -rs -o addopt=
It is outdated.
Please use USE_PYTHON=pytest instead.
See https://cgit.freebsd.org/ports/commit/Mk/Uses/python.mk?id=535f310d337c0b7de64a972bc0b855bba6c6f1f0 for details.
> Makefile:15-21
> +#USE_GITHUB= yes
> +#GH_ACCOUNT= joblib
> +
> +BUILD_DEPENDS= ${PYTHON_PKGNAMEPREFIX}build>0:devel/py-build@${PY_FLAVOR} \
> + ${PYTHON_PKGNAMEPREFIX}flit-core>0:devel/py-flit-core@${PY_FLAVOR} \
> + ${PYTHON_PKGNAMEPREFIX}installer>0:devel/py-installer@${PY_FLAVOR}
> +
Right now, I'd like to generate a setup.py before we move to pyproject.toml.
See https://gist.github.com/sunpoet/f9ee85a45f334f65afde2a3a257e1bb3 for the setup.py.
I'll add a post-patch: to update the version.
post-patch:
@${SED} -e 's|%%PORTVERSION%%|${PORTVERSION}|' ${FILESDIR}/setup.py > ${WRKSRC}/setup.py
> Makefile:24
> +
> +USES= python:3.6-3.9
> +
This should be USES=python:3.6+
See https://github.com/joblib/threadpoolctl/blob/3.1.0/pyproject.toml#L11
REPOSITORY
R11 FreeBSD ports repository
CHANGES SINCE LAST ACTION
https://reviews.freebsd.org/D35513/new/
REVISION DETAIL
https://reviews.freebsd.org/D35513
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreferences/
To: thierry, yuri, emaste_freebsdfoundation.org, wen
Cc: sunpoet, koobs, freebsd-python-list, #python
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ddca27aa1cfb78570c60410997ff149c>