Date: Sat, 9 Jan 1999 14:47:52 +0100 (CET) From: Andrzej Bialecki <abial@nask.pl> To: Kazutaka YOKOTA <yokota@zodiac.mech.utsunomiya-u.ac.jp> Cc: Andrzej Bialecki <abial@FreeBSD.ORG>, cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/i386/i386 userconfig.c Message-ID: <Pine.BSF.4.02A.9901091435190.18584-100000@korin.warman.org.pl> In-Reply-To: <199901090955.SAA08764@zodiac.mech.utsunomiya-u.ac.jp>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 9 Jan 1999, Kazutaka YOKOTA wrote: > Since INTOR_USERCONFIG was introduced a couple of months ago, I find > the behavior of the UserConfig prompt odd, if not broken. > > Even if I don't enter UserConfig, I always got "config> quit" as below > because userconfig.:getchar() returns "quit" when !RB_CONFIG. I think > such echo shouldn't be showing when the user had no intention of > running UserConfig in the first place. Yeah, I know - I think it was msmith's idea of the way it should deal with such case, because of the kludge in getchar() which checks for various flags. Needless to say it should be moved to some separate function. Perhaps it should be rewritten in whole. My fix was just to, well, make the flags work ok with present structure of userconfig. > If I do enter UserConfig by giving -c option to the kernel, I got a > banner "FreeBSD Kernel Configuration Utility...", but it shows AFTER > the first "config>" prompt. This is slightly annoying. It should be > printed BEFORE the "config>" prompt, shouldn't it? That's because the check is done inside the first invocation of getchar(), just after the "config> " prompt is printed. I agree, this should be changed, but then perhaps it would be better to rewrite this portion altogether instead of fixing yet another symptom of the real problem... Andrzej Bialecki -------------------- ++-------++ ------------------------------------- <abial@nask.pl> ||PicoBSD|| FreeBSD in your pocket? Go and see: Research & Academic |+-------+| "Small & Embedded FreeBSD" Network in Poland | |TT~~~| | http://www.freebsd.org/~picobsd/ -------------------- ~-+==---+-+ ------------------------------------- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.02A.9901091435190.18584-100000>