Date: Sat, 25 Jun 2016 13:16:40 +0300 From: Guy Yur <guyyur@gmail.com> To: Konstantin Belousov <kostikbel@gmail.com> Cc: Daniel Engberg <daniel.engberg.lists@pyret.net>, freebsd-current <freebsd-current@freebsd.org> Subject: Re: Samba 4.3 and 4.4 crashes on FreeBSD 11-ALPHA4 Message-ID: <CAC67Hz-aX5xm_34jOBd=_W%2BwrYAt5OQ%2BMPH%2BFxWWcEb4%2B4KOdA@mail.gmail.com> In-Reply-To: <20160625092040.GL38613@kib.kiev.ua> References: <CAC67Hz_BmCpbU1UONPgpGY4kNvJj9GQCoAwqOO_19vZL2-6xyQ@mail.gmail.com> <20160625084939.GI38613@kib.kiev.ua> <20160625092040.GL38613@kib.kiev.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi, On Sat, Jun 25, 2016 at 12:20 PM, Konstantin Belousov <kostikbel@gmail.com> wrote: > On Sat, Jun 25, 2016 at 11:49:39AM +0300, Konstantin Belousov wrote: >> On Sat, Jun 25, 2016 at 01:03:13AM +0300, Guy Yur wrote: >> > libtdb.so.1`tdb_runtime_check_for_robust_mutexes + 1475 at mutex.c:957 >> > ... >> >> The pointer to tdb_runtime_check_for_robust_mutexes() appeared to be >> most useful, thanks. >> >> The two patches below should fix samba use of robustness. First, >> kernel erronously reset robust lists locations on fork. Second, the >> pthread_mutex_trylock() for owned errorcheck mutex must return EDEADLK >> and not EBUSY. Try that. > > Correction, there was a reason why I initially put the rb list pointers > into zeroed region. It still needs to be zeroed on new thread creation. > Updated patch. > With the patch to the 3 files applied, smbd, nmbd and smbclient no longer crash on my machine. Tested with r302191+patch. Thanks, Guy
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAC67Hz-aX5xm_34jOBd=_W%2BwrYAt5OQ%2BMPH%2BFxWWcEb4%2B4KOdA>