Date: Tue, 27 Nov 2001 18:53:25 -0500 From: Bosko Milekic <bmilekic@technokratis.com> To: Robert Watson <rwatson@FreeBSD.org> Cc: Mike Barcroft <mike@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: Committer's guide policy on commit message contents Message-ID: <20011127185325.A17708@technokratis.com> In-Reply-To: <Pine.NEB.3.96L.1011127163632.20120A-100000@fledge.watson.org>; from rwatson@FreeBSD.org on Tue, Nov 27, 2001 at 04:37:49PM -0500 References: <20011127163513.A12400@espresso.q9media.com> <Pine.NEB.3.96L.1011127163632.20120A-100000@fledge.watson.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Nov 27, 2001 at 04:37:49PM -0500, Robert Watson wrote: > > On Tue, 27 Nov 2001, Mike Barcroft wrote: > > > From the Committers Guide: "Do not waste space in the commit messages > > explaining what you did. That is what cvs diff is for. Instead, tell > > us why you did it." > > Ignoring, for a moment, any context -- I think this is actually not a good > policy. In the event that there are complex or large changes being made, > a brief summary of the changes, along with the rationale, is appropriate > in the commit message. At least, that's my feeling :-). Is this > something that would be worth changing? As you've probably noticed, I'm not nor have I ever really followed that part of the guide. Better be a little longer and have some people go "wow, that's a good commit message!" and others go "wow, this guy has no life!" than too short and have some people stay quiet while others go "wow, that commit message sucks." In other words, the importance of size is a relative thing. ;-) [h0h0h0!] > Robert N M Watson FreeBSD Core Team, TrustedBSD Project > robert@fledge.watson.org NAI Labs, Safeport Network Services -- Bosko Milekic bmilekic@technokratis.com To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20011127185325.A17708>