Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 4 Jan 2017 14:17:29 -0800
From:      Ngie Cooper <yaneurabeya@gmail.com>
To:        Alan Somers <asomers@freebsd.org>
Cc:        "src-committers@freebsd.org" <src-committers@freebsd.org>,  "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>,  "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>
Subject:   Re: svn commit: r311305 - in head/sys: cam cam/ctl cam/scsi dev/aac dev/aacraid dev/advansys dev/aha dev/ahb dev/ahci dev/aic dev/aic7xxx dev/amr dev/arcmsr dev/ata dev/buslogic dev/ciss dev/dpt dev/es...
Message-ID:  <CAGHfRMCpHStYV2dMNs3o-_ui6ckfDqUg8kaMNPpk8cKcbhpqOw@mail.gmail.com>
In-Reply-To: <201701042026.v04KQggH076026@repo.freebsd.org>
References:  <201701042026.v04KQggH076026@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Jan 4, 2017 at 12:26 PM, Alan Somers <asomers@freebsd.org> wrote:
> Author: asomers
> Date: Wed Jan  4 20:26:42 2017
> New Revision: 311305
> URL: https://svnweb.freebsd.org/changeset/base/311305
>
> Log:
>   Always null-terminate ccb_pathinq.(sim_vid|hba_vid|dev_name)
>
>   The sim_vid, hba_vid, and dev_name fields of struct ccb_pathinq are
>   fixed-length strings. AFAICT the only place they're read is in
>   sbin/camcontrol/camcontrol.c, which assumes they'll be null-terminated.
>   However, the kernel doesn't null-terminate them. A bunch of copy-pasted code
>   uses strncpy to write them, and doesn't guarantee null-termination. For at
>   least 4 drivers (mpr, mps, ciss, and hyperv), the hba_vid field actually
>   overflows. You can see the result by doing "camcontrol negotiate da0 -v".
>
>   This change null-terminates those fields everywhere they're set in the
>   kernel. It also shortens a few strings to ensure they'll fit within the
>   16-character field.
>
>   PR:           215474
>   Reported by:  Coverity
>   CID:          1009997 1010000 1010001 1010002 1010003 1010004 1010005
>   CID:          1331519 1010006 1215097 1010007 1288967 1010008 1306000
>   CID:          1211924 1010009 1010010 1010011 1010012 1010013 1010014
>   CID:          1147190 1010017 1010016 1010018 1216435 1010020 1010021
>   CID:          1010022 1009666 1018185 1010023 1010025 1010026 1010027
>   CID:          1010028 1010029 1010030 1010031 1010033 1018186 1018187
>   CID:          1010035 1010036 1010042 1010041 1010040 1010039
>   Reviewed by:  imp, sephe, slm
>   MFC after:    4 weeks
>   Sponsored by: Spectra Logic Corp
>   Differential Revision:        https://reviews.freebsd.org/D9037
>   Differential Revision:        https://reviews.freebsd.org/D9038

Awesome -- after I make my pass at bsnmp and netbsd-tests, I'll loop
back around to help out with writing tests for cam(3).
Cheers,
-Ngie



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAGHfRMCpHStYV2dMNs3o-_ui6ckfDqUg8kaMNPpk8cKcbhpqOw>