Date: Sun, 28 Jun 2020 23:48:33 -0700 From: Oleksandr Tymoshenko <gonzo@freebsd.org> To: Li-Wen Hsu <lwhsu@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, svn-src-stable@freebsd.org, svn-src-stable-12@freebsd.org Subject: Re: svn commit: r362767 - in stable/12/usr.bin/mkimg: . tests Message-ID: <20200629064833.GA83997@bluezbox.com> In-Reply-To: <CAKBkRUyubtOBLrMO_zK%2BoaAQNjy=FZHGEZ7iG472XKS-73819w@mail.gmail.com> References: <202006290034.05T0YBU7051105@repo.freebsd.org> <CAKBkRUxZJHp95nebghMBycCXY_NR2oM-cqsDdnyGMfs8OyTCpA@mail.gmail.com> <20200629062057.GA82989@bluezbox.com> <CAKBkRUyubtOBLrMO_zK%2BoaAQNjy=FZHGEZ7iG472XKS-73819w@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Li-Wen Hsu (lwhsu@freebsd.org) wrote: > On Mon, Jun 29, 2020 at 2:21 PM Oleksandr Tymoshenko <gonzo@freebsd.org> wrote: > > > > Li-Wen Hsu (lwhsu@freebsd.org) wrote: > > > On Mon, Jun 29, 2020 at 8:36 AM Oleksandr Tymoshenko <gonzo@freebsd.org> wrote: > > > > > > > > Author: gonzo > > > > Date: Mon Jun 29 00:34:11 2020 > > > > New Revision: 362767 > > > > URL: https://svnweb.freebsd.org/changeset/base/362767 > > > > > > > > Log: > > > > MFC r361935: > > > > > > > > Add VHDX support to mkimg(1) > > > > > > > > VHDX is the successor of Microsoft's VHD file format. It increases > > > > maximum capacity of the virtual drive to 64TB and introduces features > > > > to better handle power/system failures. > > > > > > > > VHDX is the required format for 2nd generation Hyper-V VMs. > > > > > > > > Reviewed by: marcel > > > > Differential Revision: https://reviews.freebsd.org/D25184 > > > > > > Some mkimg(1) tests are failing after this merge: > > > > > > https://ci.freebsd.org/job/FreeBSD-stable-12-amd64-test/2484/ > > > https://ci.freebsd.org/job/FreeBSD-stable-12-i386-test/2466/ > > > > > > Can you check if there are something related to tests also need merging? > > > > Ooops, sorry for the breakage. Should be fixed in 362772. The problem > > was different format for the reference images. I'll wait to check if > > the commit fixes the test suite on stable/12 for sure and commit fix > > for stable/11 then. > > Thank you for the quick analysis and fix. Perhaps mering the codes to > process the new format of the reference images can easy the process of > future update and MFH? Good point. I assumed it was global change, but looks like it's just mkimg format change. I'll look into merging it both to stable/12 (and reverting current fix) and stable/11. -- gonzo
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20200629064833.GA83997>