Date: Tue, 4 Jan 2011 00:01:01 +0200 From: Kostik Belousov <kostikbel@gmail.com> To: Rick Macklem <rmacklem@uoguelph.ca> Cc: freebsd-fs@freebsd.org Subject: Re: exporting non-mpsafe file systems - VFS_NEEDSGIANT() Message-ID: <20110103220101.GH3140@deviant.kiev.zoral.com.ua> In-Reply-To: <991403850.53411.1294090462292.JavaMail.root@erie.cs.uoguelph.ca> References: <991403850.53411.1294090462292.JavaMail.root@erie.cs.uoguelph.ca>
next in thread | previous in thread | raw e-mail | index | archive | help
--+QwZB9vYiNIzNXIj Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jan 03, 2011 at 04:34:22PM -0500, Rick Macklem wrote: > Hi, >=20 > The code currently in the experimental NFS server w.r.t. handling > VFS_LOCK_GIANT()/VFS_UNLOCK_GIANT() is currently BADLY broken. > Fortunately, since the major file systems being exported are mpsafe > and don't need Giant, nobody seems to be noticing. >=20 > Since the code is ugly and not easy to fix, I'd like to just delete > it and only allow mpsafe file systems to be exported. (I looked at > ufs/zfs/nullfs/msdosfs/cs9660 and they all appear to be mpsafe.) >=20 > So does anyone know of a non-mpsafe file system that needs to be > exported or see other serious problems w.r.t. not allowing exporting > of non-mpsafe file systems? The only sami-important fs that is not mpsafe is smbfs. I would say, go with the removal of VFS_LOCK_GIANT from the new nfs server. --+QwZB9vYiNIzNXIj Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (FreeBSD) iEYEARECAAYFAk0iRx0ACgkQC3+MBN1Mb4j51QCghcRJbclbfQfKp/EYSlralTwx fRAAn3oK9sBvrSInJ2faqOmIsdIXuezU =lgZZ -----END PGP SIGNATURE----- --+QwZB9vYiNIzNXIj--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20110103220101.GH3140>