Date: Thu, 04 Apr 2019 23:33:02 +0000 From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 230792] sort -R, --random-source issues Message-ID: <bug-230792-227-FJfcPAzemP@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-230792-227@https.bugs.freebsd.org/bugzilla/> References: <bug-230792-227@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D230792 --- Comment #3 from commit-hook@freebsd.org --- A commit references this bug: Author: cem Date: Thu Apr 4 23:32:27 UTC 2019 New revision: 345896 URL: https://svnweb.freebsd.org/changeset/base/345896 Log: sort(1): randomcoll: Skip the memory allocation entirely There's no reason to order based on strcmp of ASCII digests instead of memcmp of the raw digests. While here, remove collision fallback. If you collide two MD5s, they're probably the same string anyway. If robustness against MD5 collisions is desired, maybe we shouldn't use MD5. None of the behavior of sort -R is specified by POSIX, so we're free to implement this however we like. E.g., using a 128-bit counter and block cipher to generate unique indices for each line of input. PR: 230792 (2/many) Relnotes: This will change the sort order for a given dataset with a given seed. Other similarly breaking changes are planned. Sponsored by: Dell EMC Isilon Changes: head/usr.bin/sort/coll.c --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-230792-227-FJfcPAzemP>