Date: Fri, 07 Dec 2007 11:51:06 +0100 From: =?ISO-8859-1?Q?S=F8ren_Schmidt?= <sos@deepcore.dk> To: "Andrey V. Elsukov" <bu7cher@yandex.ru> Cc: =?ISO-8859-1?Q?S=F8ren_Schmidt?= <sos@FreeBSD.ORG>, "Julian H. Stacey" <jhs@berklix.org>, freebsd-current@FreeBSD.ORG, Todd Wasson <tsw5@duke.edu> Subject: Re: BETA4 installer doesn't attach my HDD controller; BETA3 did Message-ID: <4759259A.3070000@deepcore.dk> In-Reply-To: <4758FC14.2080606@yandex.ru> References: <1B3A2410-9C2A-4126-AC92-8E38B4A0D79A@duke.edu> <200712061726.lB6HQCIu023253@fire.js.berklix.net> <C8EA53AF-B580-40D7-AFDB-E4F8C3DB8233@duke.edu> <4758FC14.2080606@yandex.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
This is a multi-part message in MIME format.
--------------000006040706060003020003
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: quoted-printable
Andrey V. Elsukov wrote:
> Todd Wasson wrote:
>>> Todd Wasson wrote:
>>>> I've got a Maxtor 6Y080L0 YAR41VW0 drive on a JMicron JMB368 UDMA133=
>>>> controller, and in the BETA4 installer the controller doesn't seem t=
o
>>>> be properly attaching, which leads to the drive not being found. Th=
e
>>>> relevant sections from dmesg (as I'm not sure where else to look whi=
le
>>>> running the installer CD) are:
>>>
>>> Did you try "Safe Boot" key 3.
>
> I think this changes may create a regression:
>
> 1. the BETA3's version:
>
> ctlr->r_type2 =3D SYS_RES_MEMORY;
> ctlr->r_rid2 =3D PCIR_BAR(5);
> if ((ctlr->r_res2 =3D bus_alloc_resource_any(dev, ctlr->r_type2=
,
> &ctlr->r_rid2, RF_ACTIVE))){
> if ((error =3D ata_ahci_chipinit(dev)))
> return error;
> }
> We have two checks here. Probably your controller doesn't allocate a
> memory resource for the AHCI, but it works because it skips second
> checks.
>
> 2. the BETA4's version:
>
> if ((error =3D ata_ahci_chipinit(dev)))
> return error;
>
> In this version driver doesn't pass it. I've already sent patch
> for test to your PR, but i attach it again.
> May be Soren can comment it?
Yeah, there's a bug allright, attached patch is the right way to fix it, =
I'll commit when I get a few..
-S=F8ren
--------------000006040706060003020003
Content-Type: text/plain; x-mac-type="0"; x-mac-creator="0"; name="JMicrom-p1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
filename="JMicrom-p1"
? JMicrom-p1
? ich-sata-fix
Index: ata-chipset.c
===================================================================
RCS file: /home/ncvs/src/sys/dev/ata/ata-chipset.c,v
retrieving revision 1.209
diff -u -r1.209 ata-chipset.c
--- ata-chipset.c 26 Nov 2007 19:08:08 -0000 1.209
+++ ata-chipset.c 7 Dec 2007 10:49:06 -0000
@@ -2260,7 +2309,7 @@
pci_write_config(dev, 0x40, 0x80c0a131, 4);
pci_write_config(dev, 0x80, 0x01200000, 4);
- if ((error = ata_ahci_chipinit(dev)))
+ if (ctlr->chip->cfg1 && (error = ata_ahci_chipinit(dev)))
return error;
ctlr->allocate = ata_jmicron_allocate;
--------------000006040706060003020003--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4759259A.3070000>