Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 28 Aug 2009 00:21:26 -0400 (EDT)
From:      Mike Andrews <mandrews@bit0.com>
To:        "Li, Qing" <qing.li@bluecoat.com>
Cc:        freebsd-current@freebsd.org, Larry Baird <lab@gta.com>
Subject:   RE: 8.0-BETA3 reproducible panic under load
Message-ID:  <alpine.BSF.2.00.0908280020270.60783@beast.int.bit0.com>
In-Reply-To: <B583FBF374231F4A89607B4D08578A43052773AF@bcs-mail03.internal.cacheflow.com>
References:  <109727.111234.43119@localhost> <20090827181522.81970.qmail@mailgate.gta.com> <B583FBF374231F4A89607B4D08578A43052773AF@bcs-mail03.internal.cacheflow.com>

next in thread | previous in thread | raw e-mail | index | archive | help

On Thu, 27 Aug 2009, Li, Qing wrote:

>>
>> Not sure if this is what you hit or not.  I once saw something
> similar.
>> The call to LLE_FREE() in ip_output doesn't expect NULL.  Adding
>>    if (ro->ro_lle != NULL)
>> just before the call to LLE_FREE() may fix your crashes.
>>
>
> Actually, LLE_FREE() should not be called at all here because the
> "if (!nortfree)" block test applies to route entries that are not
> from the flow-table.  And if the route entry is not from the
> flow-table, then the rt_lle field is invalid.
>
> I will commit the fix.

I commented the LLE_FREE() call out over here, and it seems to have 
stabilized the machine -- no panics in over 5 hours, where previously i 
could get one within 5 minutes.  Thanks!

Any ETA on when the commit will hit RELENG_8?



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?alpine.BSF.2.00.0908280020270.60783>