Date: Thu, 21 Sep 2023 07:52:11 +0000 From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 273148] [PATCH] scripted installs are unable to verify checksums for fetched dists Message-ID: <bug-273148-227-x9Lovdm9YG@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-273148-227@https.bugs.freebsd.org/bugzilla/> References: <bug-273148-227@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D273148 --- Comment #10 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3Dc0e249d32c780ee8240fe8b3b8144078a= 8eec41f commit c0e249d32c780ee8240fe8b3b8144078a8eec41f Author: Lars Kellogg-Stedman <lars@oddbit.com> AuthorDate: 2023-08-15 15:44:02 +0000 Commit: Corvin K=C3=B6hne <corvink@FreeBSD.org> CommitDate: 2023-09-21 06:41:48 +0000 bsdinstall: avoid conflicts with fd 3 Throughout the bsdinstall script fd 3 is used by f_dprintf (set through $TERMINAL_STDOUT_PASSTHRU). In several places in the bsdinstalls script= s, we use fd 3 to juggle stdout when calling out to other tools, which can cause the installer to fail with a "Bad file descriptor" error when f_dprintf attempts to use it. This commit replaces all constructs like this: exec 3>&1 SOME_VARIABLE=3D$(some command 2>&1 1>&3) exec 3>&- With: exec 5>&1 SOME_VARIABLE=3D$(some command 2>&1 1>&5) exec 5>&- PR: 273148 Reviewed by: corvink Fixes: 1f7746d81f53447ac15cc99395bb714d4dd0a4da ("bsdinstall: stop messing with file descriptors") MFC after: 1 week usr.sbin/bsdinstall/scripts/auto | 22 +++++++++++----------- usr.sbin/bsdinstall/scripts/fetchmissingdists | 6 +++--- usr.sbin/bsdinstall/scripts/hardening | 6 +++--- usr.sbin/bsdinstall/scripts/jail | 16 ++++++++-------- usr.sbin/bsdinstall/scripts/mirrorselect | 12 ++++++------ usr.sbin/bsdinstall/scripts/netconfig | 12 ++++++------ usr.sbin/bsdinstall/scripts/netconfig_ipv4 | 6 +++--- usr.sbin/bsdinstall/scripts/netconfig_ipv6 | 6 +++--- usr.sbin/bsdinstall/scripts/script | 13 ++++++------- usr.sbin/bsdinstall/scripts/services | 6 +++--- usr.sbin/bsdinstall/scripts/time | 12 ++++++------ 11 files changed, 58 insertions(+), 59 deletions(-) --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-273148-227-x9Lovdm9YG>