Date: Tue, 18 Jun 1996 12:14:49 +0200 (MET DST) From: "Julian H. Stacey" <jhs@freebsd.org> To: current@freebsd.org Cc: jkh@freebsd.org Subject: xditview Message-ID: <199606181014.MAA01844@vector.jhs.no_domain>
next in thread | raw e-mail | index | archive | help
It seems xditview was removed from src/gnu/usr.bin/groff/
(with today's just received ctm patch: src-cur.1896)
I seem to recall someone complaining it wouldnt compile if there was no
X tree resident, could it have been removed just because of that ? !
A better solution may be something like:
src/gnu/usr.bin/groff/Makefile:
.if exists(${X11BASE}/include)
.if exists(${X11BASE}/lib)
SUBDIR +=xditview
Could whoever removed xditview please consider restoring it,
& adding a .if exists ?
Losing functionality seems questionable, as even if net people aren't using
it, at next cd-rom upgrade, it'll likely sting some non-net users.
(& BTW I guess it's good to remember: Those silent non code contributing
FreeBSD users are still useful, as customers of WC & FreeBSD consultants :-) )
PS I detected this as ctm reported "md5 mismatch" as
I had the following patch in use:
http://www.freebsd.org/~jhs/src/bsd/fixes/FreeBSD/src/generic/gnu/usr.bin/groff/xditview/Makefile.DESTDIR.diff
==============
If you happen to compile with something like
DESTDIR=/usr/dest//usr2/data/freebsd/src.940225
& that DESTDIR has no X386 tree, it doesnt compile.
If you later say, "yes that compiled clean, Im happy, install in /"
(which does have an X tree)
setenv DESTDIR /
make install
it blows up because it never compiled !
Solution:
compile on one set of if's
install on a larger set of if's
*** old/src/gnu/usr.bin/groff/xditview/Makefile Sat Dec 3 19:40:18 1994
--- new/src/gnu/usr.bin/groff/xditview/Makefile Sat Dec 3 19:44:23 1994
***************
*** 1,8 ****
.if exists(${X11BASE}/include)
.if exists(${X11BASE}/lib)
- .if exists(${DESTDIR}${X11BASE}/bin)
- .if exists(${DESTDIR}${X11BASE}/man/man1)
- .if exists(${DESTDIR}${X11BASE}/lib/X11/app-defaults)
BINDIR= ${X11BASE}/bin
MANDIR= ${X11BASE}/man/man
--- 1,5 ----
***************
*** 17,22 ****
--- 14,22 ----
${X11BASE}/lib/libXt.a ${X11BASE}/lib/libXext.a \
${X11BASE}/lib/libX11.a
+ .if exists(${DESTDIR}${X11BASE}/bin)
+ .if exists(${DESTDIR}${X11BASE}/man/man1)
+ .if exists(${DESTDIR}${X11BASE}/lib/X11/app-defaults)
afterinstall:
install -c -o ${BINOWN} -g ${BINGRP} -m 444 \
${.CURDIR}/GXditview.ad \
==============
Julian
--
Julian H. Stacey jhs@freebsd.org http://www.freebsd.org/~jhs/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199606181014.MAA01844>