Date: Sat, 29 Feb 2020 12:10:55 -0800 From: Chris <bsd-lists@BSDforge.com> To: Sean Yeh <sean.yeh117@gmail.com> Cc: <freebsd-pf@freebsd.org> Subject: Re: ALTQ feature of PF in FreeBSD Message-ID: <e40366c114d1c2b270a1d26912700347@udns.ultimatedns.net> In-Reply-To: <CAOeSqSdvsSz6khNU95zMa-6BhyyFvJiwb=JH6vt-e9yQuivzpw@mail.gmail.com>
index | next in thread | previous in thread | raw e-mail
On Sat, 29 Feb 2020 05:27:42 -0800 Sean Yeh sean.yeh117@gmail.com said > > On Fri, Feb 28, 2020 at 8:37 PM Chris <bsd-lists@bsdforge.com> wrote: > > > On Fri, 28 Feb 2020 15:35:23 -0800 Sean Yeh sean.yeh117@gmail.com said > > > > > Hi FreeBSD-pf members, > > > > > > I hope you guys are enjoying your weekend! > > > > > > I was wondering if any of you happened to know if the code for the ALTQ > > > feature of pf could be separated and used for NetBSD's pf function. I'm > > > currently investigating methods to improve NetBSD's ALTQ feature, which > > > hasn't been updated in 15+ years: > > > https://wiki.netbsd.org/projects/project/altq/ > > > > > > According to the man pages of freeBSD's pf function, FreeBSD uses a > > > modified pf of openBSD 4.5 pf function. Are there any complications that > > > you foresee trying to port FreeBSD's current ALTQ code into NetBSD? > > In all honesty. If you have to ask. You will likely find it challenging. > > ;) ;) > > But *please* don't let that discourage you! > > If you're a kernel hacker, and or have a good eye for patterns. You should > > be able to find the similarities by different names to match them up. > > But that doesn't mean that in the end it'll work. I haven't personally > > made any comparisons. I'm only familiar with the FreeBSD variety. > > > > My 2ยข FWIW :) > > > > --Chris > > FreeBSD 14.0-FUTURE #0.000 cray256 > > > > > > > > Thank you for all your help, > > > > > > Sean > -------------------------------------------------- > reflowed for context. Because top posting is evil > -------------------------------------------------- > > Hi Chris (and FreeBSD-pf members), > > Thanks for the advice! > > Truth be told, I am quite lost right now. But before I give up, could you > please point me in the right direction? > > 1) Figuring out if ALTQ is separable from pf is a little abstract to me. > Is there a definitive experiment to perform to answer this question? > Currently, I'm just looking and taking note of the differences between > NetBSD's and FreeBSD's pf/altq code. What other steps should I be > taking? First off, let me state. That you're intentions are admirable, and what follows is not intended to be denigrating in any way. That said; my first statement still holds. Many have wanted to take on and make improvements, and changes to the pf(4), and altq(4) source -- more so to pf. But quickly discovered the sheer complexity of the routines, and algos of the source. I could liken them to crypto routines. Many of these were seasoned programmers/hackers. So the code is brittle, and resistant to change except to those well familiar. If you're the tenacious type, like myself. I would say your first step needs to become well familiar with the source. Immerse yourself in it. You'll quickly discover that you need to become familiar with the kernel source, as well. Oh, and you're a net guru. Right? ;) I'm serious. That's what it's going to take, to have any meaningful conversation regarding the changes you propose -- and I'm happy to have them with you. If you want to proceed. :) If I haven't scared you off. I'll look forward to hearing from you. :) --Chris > > 2) What are some indications that a port will fail/work? > When I find a difference between NetBSD's and FreeBSD's code, > I've already discovered several, what questions should I ask myself > to determine whether or not the difference will be an issue or not. > > I'm sorry if these questions seem trivial or basic. I am truly > appreciative of all your time and help. > > Best, > > Seanhome | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?e40366c114d1c2b270a1d26912700347>