Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 01 Jun 2009 10:43:58 -0600 (MDT)
From:      "M. Warner Losh" <imp@bsdimp.com>
To:        rse@FreeBSD.org
Cc:        svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org
Subject:   Re: svn commit: r193223 - head/bin/sh
Message-ID:  <20090601.104358.-345495454.imp@bsdimp.com>
In-Reply-To: <200906011111.n51BBkZt077175@svn.freebsd.org>
References:  <200906011111.n51BBkZt077175@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
In message: <200906011111.n51BBkZt077175@svn.freebsd.org>
            "Ralf S. Engelschall" <rse@FreeBSD.org> writes:
: Author: rse
: Date: Mon Jun  1 11:11:46 2009
: New Revision: 193223
: URL: http://svn.freebsd.org/changeset/base/193223
: 
: Log:
:   align coding style with style(9) to avoid misunderstandings
: 
: Modified:
:   head/bin/sh/exec.c
: 
: Modified: head/bin/sh/exec.c
: ==============================================================================
: --- head/bin/sh/exec.c	Mon Jun  1 11:02:09 2009	(r193222)
: +++ head/bin/sh/exec.c	Mon Jun  1 11:11:46 2009	(r193223)
: @@ -187,7 +187,8 @@ padvance(char **path, char *name)
:  	if (*path == NULL)
:  		return NULL;
:  	start = *path;
: -	for (p = start ; *p && *p != ':' && *p != '%' ; p++);
: +	for (p = start; *p && *p != ':' && *p != '%'; p++)
: +		; /* nothing */

C already has a way of saying this:

	for (p = start; *p && *p != ':' && *p != '%'; p++)
		contionue;

Warner



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090601.104358.-345495454.imp>