Date: Mon, 18 Mar 2002 23:49:47 -0800 From: Peter Wemm <peter@wemm.org> To: Bruce Evans <bde@FreeBSD.org> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/conf kern.post.mk Message-ID: <20020319074947.F36BF3810@overcee.wemm.org> In-Reply-To: <200203190630.g2J6UOB35191@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Bruce Evans wrote:
> bde 2002/03/18 22:30:24 PST
>
> Modified files:
> sys/conf kern.post.mk
> Log:
> Removed env(1) commands. make(1) uses a real shell, and
> "env name=value ... cmd ..." is just a pessimized way of doing
> "name=value ... cmd ..." in real shells. Set the environment
> (without using env(1)) before starting xargs so that env(1)
> is not needed in "xargs env name=value ... cmd ..."
BZZT! Wrong! You broke cross compiles!
peter@overcee[11:44pm]~/fbp4/ia64/sys/ia64/compile/SMALL-273> make depend
rm -f .olddep
if [ -f .depend ]; then mv .depend .olddep; fi
make _kernel-depend
if [ -f .olddep ]; then mv .olddep .depend; fi
rm -f .newdep
MKDEP_CPP="ia64-unknown-freebsd5.0-gcc -E" CC="ia64-unknown-freebsd5.0-gcc" make -V CFILES -V SYSTEM_CFILES -V GEN_CFILES | xargs mkdep -a -f .newdep -O -pipe -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -Wno-format -ffreestanding -g -nostdinc -I- -I. -I../../.. -I../../../dev -I../../../contrib/dev/acpica -I../../../contrib/ipfilter -I../../../../include -D_KERNEL -ffreestanding -include opt_global.h -fno-common -ffixed-r13 -mfixed-range=f32-f127
../../../kern/subr_trap.c:42: opt_npx.h: No such file or directory
../../../dev/kbd/atkbd.c:44: machine/psl.h: No such file or directory
../../../dev/kbd/atkbd.c:45: machine/vm86.h: No such file or directory
mkdep: compile failed
*** Error code 1
If I back out this part of the change, it works again:
==== //depot/projects/ia64/sys/conf/kern.post.mk#5 - /home/peter/fbp4/ia64/sys/conf/kern.post.mk ====
@@ -98,12 +98,10 @@
${SYSTEM_SFILES} ${MFILES:T:S/.m$/.h/}
if [ -f .olddep ]; then mv .olddep .depend; fi
rm -f .newdep
- MKDEP_CPP="${CC} -E" CC="${CC}" \
- ${MAKE} -V CFILES -V SYSTEM_CFILES -V GEN_CFILES | xargs \
- mkdep -a -f .newdep ${CFLAGS}
- MKDEP_CPP="${CC} -E" \
- ${MAKE} -V SFILES -V SYSTEM_SFILES | xargs \
- mkdep -a -f .newdep ${ASM_CFLAGS}
+ ${MAKE} -V CFILES -V SYSTEM_CFILES -V GEN_CFILES | xargs \
+ env MKDEP_CPP="${CC} -E" CC="${CC}" mkdep -a -f .newdep ${CFLAGS}
+ ${MAKE} -V SFILES -V SYSTEM_SFILES | xargs \
+ env MKDEP_CPP="${CC} -E" mkdep -a -f .newdep ${ASM_CFLAGS}
rm -f .depend
mv .newdep .depend
The env commands are needed here, because xargs(1) doesn't understand it
otherwise.
IMHO, this part of the change is completely bogus. You are overriding the
MKDEP_CPP and CC variables on the wrong command!
Cheers,
-Peter
--
Peter Wemm - peter@wemm.org; peter@FreeBSD.org; peter@yahoo-inc.com
"All of this is for nothing if we don't go to the stars" - JMS/B5
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020319074947.F36BF3810>