Date: Mon, 01 Mar 2004 16:07:00 -0600 From: Peter Schultz <pmes@bis.midco.net> To: "Danny J. Zerkel" <dzerkel@columbus.rr.com> Cc: current@freebsd.org Subject: Re: Mozilla problems on current -- fix Message-ID: <4043B404.9000304@bis.midco.net> In-Reply-To: <404399A6.8080303@columbus.rr.com> References: <404399A6.8080303@columbus.rr.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Danny J. Zerkel wrote:
> Looks like John's sys/kern/kern_thread.c 1.171 broke Mozilla (and
> threading in general). He appears to have left out a test that
> the sleeping thread is interruptable in one spot:
>
> --- kern_thread.c.orig Mon Mar 1 15:08:01 2004
> +++ kern_thread.c Mon Mar 1 14:26:30 2004
> @@ -646,7 +646,8 @@
> } else if (TD_ON_SLEEPQ(td2) &&
> ((td2->td_wchan == &kg->kg_completed) ||
> (td2->td_wchan == &p->p_siglist &&
> - (ku->ku_mflags & KMF_WAITSIGEVENT)))) {
> + (ku->ku_mflags & KMF_WAITSIGEVENT))) &&
> + (td2->td_flags & TDF_SINTR)) {
> sleepq_abort(td2);
> } else {
> ku->ku_flags |= KUF_DOUPCALL;
>
> This change fixes my Mozilla hangs and other panics on current.
>
Do you have ULE and ADAPTIVE_MUTEXES in your kernel conf?
Thanks,
Pete...
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4043B404.9000304>