Date: Sun, 27 Apr 2003 14:50:46 +0200 (CEST) From: Harti Brandt <brandt@fokus.fraunhofer.de> To: "David O'Brien" <obrien@FreeBSD.org> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/modules Makefile src/sys/pci if_en_pci.c midwayvar.h Message-ID: <20030427144646.G61593@beagle.fokus.fraunhofer.de> In-Reply-To: <20030426160225.GA8241@dragon.nuxi.com> References: <200304251614.h3PGE3t5006537@repoman.freebsd.org> <20030426160225.GA8241@dragon.nuxi.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 26 Apr 2003, David O'Brien wrote: DO>On Fri, Apr 25, 2003 at 09:14:03AM -0700, Hartmut Brandt wrote: DO>> Modified files: DO>> sys/modules Makefile DO>> sys/pci if_en_pci.c DO>> sys/dev/en midway.c midwayreg.h midwayvar.h DO>> Added files: DO>> sys/modules/en Makefile DO>> Log: DO>> Convert the midway driver to use busdma. Except for this conversion the DO>> following changes have been done: DO>> DO>> - stylify. The original code was too hard to read. DO>> - get rid of a number of compilation options (Adaptec-only, Eni-only, no-DMA). DO>> - more debugging features. DO>> - locking. This is not correct yet in the absence of interface layer locking, DO> DO>Were you not aware we have rules against exactly this type of commit?? DO>It is totally impossible to tell what the real changes were and which the DO>style changes were. Please don't make a commits like this again. All this stuff was ready before I got my commit bit. At that time I did not care. After that, given that actually only a handful people care about this driver, I thought that it makes not much sense to do the work twice and factor out the style changes from the patch. I don't have another patch of this kind, so don't be afraid... harti -- harti brandt, http://www.fokus.fraunhofer.de/research/cc/cats/employees/hartmut.brandt/private brandt@fokus.fraunhofer.de, harti@freebsd.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030427144646.G61593>