Date: Thu, 13 Mar 2003 04:44:06 -0800 (PST) From: Hartmut Brandt <harti@FreeBSD.org> To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/net if_atm.h if_atmsubr.c Message-ID: <200303131244.h2DCi6hB035683@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
harti 2003/03/13 04:44:06 PST
FreeBSD src repository
Modified files:
sys/net if_atm.h if_atmsubr.c
Log:
This corrects a longstanding endian bug in processing LLC/SNAP encoded
frames. A comment in if_atm.h suggests that both macros, that for extracting
the ethertype and that for inserting it, handle their argument in host
byte order. In fact, the inserting macro treated its argument as an opposite
host order short and the calling code feeds it the result of htons(). This
happens to work on i386, but fails on sparc. Make the macro use real host
endianess.
Reviewed by: kjc, atm@
Revision Changes Path
1.6 +2 -2 src/sys/net/if_atm.h
1.24 +3 -3 src/sys/net/if_atmsubr.c
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200303131244.h2DCi6hB035683>