Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 13 Mar 2025 16:54:11 GMT
From:      Gleb Smirnoff <glebius@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: c78a14a2b872 - main - inpcb: in_pcb_lport_dest() doesn't use lportp as input argument
Message-ID:  <202503131654.52DGsBSc043675@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by glebius:

URL: https://cgit.FreeBSD.org/src/commit/?id=c78a14a2b872b0f82326d5bc00ec99513b3961e6

commit c78a14a2b872b0f82326d5bc00ec99513b3961e6
Author:     Gleb Smirnoff <glebius@FreeBSD.org>
AuthorDate: 2025-03-13 16:53:40 +0000
Commit:     Gleb Smirnoff <glebius@FreeBSD.org>
CommitDate: 2025-03-13 16:53:40 +0000

    inpcb: in_pcb_lport_dest() doesn't use lportp as input argument
    
    This assignment just created false positive analyzer report.
    
    CID:                    1593692
---
 sys/netinet/in_pcb.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/sys/netinet/in_pcb.c b/sys/netinet/in_pcb.c
index 47852a8cda4b..a14792649519 100644
--- a/sys/netinet/in_pcb.c
+++ b/sys/netinet/in_pcb.c
@@ -826,7 +826,6 @@ in_pcb_lport_dest(const struct inpcb *inp, struct sockaddr *lsa,
 #endif
 
 	tmpinp = NULL;
-	lport = *lportp;
 
 	if (V_ipport_randomized)
 		*lastport = first + (arc4random() % (last - first));



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202503131654.52DGsBSc043675>