Date: Tue, 26 Feb 2002 12:51:41 -0800 From: Brooks Davis <brooks@one-eyed-alien.net> To: Mikhail Teterin <mi@aldan.algebra.com> Cc: brooks@FreeBSD.org, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/awi if_awi_pccard.c Message-ID: <20020226125141.A21438@Odin.AC.HMC.Edu> In-Reply-To: <200202262044.g1QKigX25029@aldan.algebra.com>; from mi@aldan.algebra.com on Tue, Feb 26, 2002 at 03:44:40PM -0500 References: <200202262009.g1QK9Kv90960@freefall.freebsd.org> <200202262044.g1QKigX25029@aldan.algebra.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--cWoXeonUoKmBZSoM Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Feb 26, 2002 at 03:44:40PM -0500, Mikhail Teterin wrote: > On 26 Feb, Brooks Davis wrote: > > brooks 2002/02/26 12:09:19 PST > >=20 > > Modified files: > > sys/dev/awi if_awi_pccard.c=20 > > Log: > > Set ifp->if_name to "awi" instead of device_get_name(dev) to avoid > > casting away a const qualifier so the awi driver compiles. >=20 > Is not this workaround an indication, that device_get_name(dev) should > be returning ``const char*''? The problem is that device_get_name IS returning "const char*". ifp->if_name is not const so the assignment discards the qualifier. I suspect we could change that, but this change is pretty harmless. -- Brooks --=20 Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4 --cWoXeonUoKmBZSoM Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.6 (GNU/Linux) Comment: For info see http://www.gnupg.org iD8DBQE8e/VcXY6L6fI4GtQRAjGpAKDWvdnsHLmVMAJe+4Q1ieZIXDhw5gCfV70J 29DYTz0yRSSo/rBF6JsWc3U= =ZoBp -----END PGP SIGNATURE----- --cWoXeonUoKmBZSoM-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020226125141.A21438>