Date: Wed, 26 Feb 2025 10:06:21 +0100 From: tuexen@freebsd.org To: "Bjoern A. Zeeb" <bz@FreeBSD.org> Cc: "src-committers@freebsd.org" <src-committers@FreeBSD.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@FreeBSD.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@FreeBSD.org> Subject: Re: git: 0e58542fd246 - main - tcp: remove unused field from struct tcpcb Message-ID: <1B9ED49E-E36A-4C0A-A47E-C97569C2354C@freebsd.org> In-Reply-To: <r6pqp489-s4oq-0p8q-6r68-3931pss41s33@SerrOFQ.bet> References: <202502252048.51PKm4YX061305@gitrepo.freebsd.org> <r6pqp489-s4oq-0p8q-6r68-3931pss41s33@SerrOFQ.bet>
next in thread | previous in thread | raw e-mail | index | archive | help
> On 26. Feb 2025, at 03:23, Bjoern A. Zeeb <bz@FreeBSD.org> wrote: >=20 > On Tue, 25 Feb 2025, Michael Tuexen wrote: >=20 >> The branch main has been updated by tuexen: >>=20 >> URL: = https://cgit.FreeBSD.org/src/commit/?id=3D0e58542fd246242bc64bd03d8b2f28cf= 981c062b >>=20 >> commit 0e58542fd246242bc64bd03d8b2f28cf981c062b >> Author: Peter Lei <peterlei@netflix.com> >> AuthorDate: 2025-02-25 20:37:48 +0000 >> Commit: Michael Tuexen <tuexen@FreeBSD.org> >> CommitDate: 2025-02-25 20:37:48 +0000 >>=20 >> tcp: remove unused field from struct tcpcb >>=20 >> Reviewed by: tuexen >> Sponsored by: Netflix, Inc. >> --- >> sys/netinet/tcp_var.h | 1 - >> 1 file changed, 1 deletion(-) >>=20 >> diff --git a/sys/netinet/tcp_var.h b/sys/netinet/tcp_var.h >> index e65e44840bd8..31663ed48f81 100644 >> --- a/sys/netinet/tcp_var.h >> +++ b/sys/netinet/tcp_var.h >> @@ -452,7 +452,6 @@ struct tcpcb { >> tcp_seq gput_seq; /* Outbound measurement seq */ >> tcp_seq gput_ack; /* Inbound measurement ack */ >> int32_t t_stats_gput_prev; /* XXXLAS: Prev gput measurement */ >> - uint32_t t_maxpeakrate; /* max peak rate set by user, bytes/s */ >=20 > Is the tcpcb no longer KBI relevant these days? > In the old days we'd simply make this a spare and not move all offsets > below around. I can do that, if it is preferred. I was actually thinking about this, but did not find any variable in the struct which indicates it is = unused, spare or so. I do know that the size of the structure matters (smaller = is better). So please let me know. I will not MFC this change. Best regards Michael >=20 >> uint32_t t_sndtlppack; /* tail loss probe packets sent */ >> uint64_t t_sndtlpbyte; /* total tail loss probe bytes sent */ >> uint64_t t_sndbytes; /* total bytes sent */ >>=20 >=20 > --=20 > Bjoern A. Zeeb = r15:7
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1B9ED49E-E36A-4C0A-A47E-C97569C2354C>