Date: Wed, 23 Jan 2013 11:46:13 +0100 From: Erik Cederstrand <erik@cederstrand.dk> To: Konstantin Belousov <kostikbel@gmail.com> Cc: "toolchain@freebsd.org" <toolchain@freebsd.org> Subject: Re: [patch] DEBUG_FLAGS cleanup Message-ID: <13E7EB8C-6815-4969-A3B2-F02A2BC28D5B@cederstrand.dk> In-Reply-To: <20130123100558.GV2522@kib.kiev.ua> References: <0CBACA33-7420-4045-AD0C-852983CD64CF@cederstrand.dk> <20130123100558.GV2522@kib.kiev.ua>
index | next in thread | previous in thread | raw e-mail
Den 23/01/2013 kl. 11.05 skrev Konstantin Belousov <kostikbel@gmail.com>: > On Wed, Jan 23, 2013 at 09:23:41AM +0100, Erik Cederstrand wrote: >> [...] >> >> -CFLAGS+= -g >> +CFLAGS+= $(DEBUG_FLAGS) >> CFLAGS+= -DGENERATOR_FILE -DHAVE_CONFIG_H >> >> # Override LIBIBERTY set by Makefile.inc, We use our own for > > This fragment catched my eye, and it is typical for the patch. > Why do you need to add DEBUG_FLAGS to the CFLAGS manually ? > Wouldn't share/mk magic do this automatically ? Quite possibly. My only reason for this approach was to change as little as possible. I'll test if I can just remove the line entirely. Thanks, Erikhelp
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?13E7EB8C-6815-4969-A3B2-F02A2BC28D5B>