Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 23 Jan 2022 23:12:27 +0000
From:      bugzilla-noreply@freebsd.org
To:        ruby@FreeBSD.org
Subject:   [Bug 260207] www/rubygem-gollum update to latest 5.2.3
Message-ID:  <bug-260207-21402-oeXoUSok3c@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-260207-21402@https.bugs.freebsd.org/bugzilla/>
References:  <bug-260207-21402@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D260207

--- Comment #17 from Po-Chuan Hsieh <sunpoet@FreeBSD.org> ---
Hi,

Please complete the following changes before closing this PR.

1. Add back the upper bound to RUN_DEPENDS
For example, "gemojione ~> 4.1" should be written as
"rubygem-gemojione>=3D4.1<5:graphics/rubygem-gemojione" instead of
"rubygem-gemojione>=3D4.1:graphics/rubygem-gemojione".
It makes easier to check dependent ports to avoid breakage while updating
rubygem ports.

2. Remove duplicate graphics/rubygem-gemojione in
www/rubygem-gollum-lib/Makefile

3. Fix the inconsistency between Makefile and gemspec, e.g. rugged in
www/rubygem-gollum-rugged_adapter

4. It would be better to make minimal changes to gemspec
Take www/rubygem-gollum-rugged_adapter for example, it's sufficient to chan=
ge
mime-types from "~> 1.15" to ">=3D 1.15".

Thanks.

--=20
You are receiving this mail because:
You are on the CC list for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-260207-21402-oeXoUSok3c>